Hi Maxime.

Looks good, but spotted two small issues.

> +#include <drm/drm_mipi_dsi.h>
> +#include <drm/drm_modes.h>
> +#include <drm/drm_panel.h>
> +#include <drm/drm_print.h>
> +
> +#include <video/mipi_display.h>


> +#include <video/of_display_timing.h>
> +#include <video/videomode.h>
These are no longer used as far as I can see.


> +
> +     /* Reset */

/* Enable power and de-assert reset */?

> +     msleep(20);
> +     gpiod_set_value(ctx->gpios.power, 1);
> +     msleep(20);
> +     gpiod_set_value(ctx->gpios.reset, 1);
> +     msleep(20);


        Sam

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Reply via email to