Hi Thierry.
> > + case TPG110_RES_480X272:
> > + dev_info(tpg->dev, "480x272 RGB");
> > + break;
> > + case TPG110_RES_640X480:
> > + dev_info(tpg->dev, "640x480 RGB");
> > + break;
> > + case TPG110_RES_800X480:
> > + dev_info(tpg->dev, "800x480 RGB");
> > + break;
> > + default:
> > + dev_info(tpg->dev, "ILLEGAL RESOLUTION");
>
> dev_err()? Also, perhaps make this some proper error message and include
> the invalid value?
>
> Also I just noticed that the above informational messages all lack a \n
> at the end.
The "\n" is optional these days.
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
