Hi Shayenne,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on robclark/msm-next]
[also build test ERROR on v4.20-rc7 next-20181221]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:    
https://github.com/0day-ci/linux/commits/Shayenne-Moura/drm-Remove-drm_mode_object-dependency-from-drm_display_mode/20181221-161831
base:   git://people.freedesktop.org/~robclark/linux msm-next
config: arm64-defconfig (attached as .config)
compiler: aarch64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=arm64 

All error/warnings (new ones prefixed by >>):

   In file included from include/drm/drm_mm.h:49:0,
                    from include/drm/drmP.h:72,
                    from include/drm/drm_modeset_helper.h:26,
                    from include/drm/drm_crtc_helper.h:44,
                    from drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c:22:
   drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c: In function 
'mdp5_crtc_mode_set_nofb':
>> drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c:387:23: error: expected ')' before 
>> 'DMR_MODE_FMT'
     DBG("%s: set mode: " DMR_MODE_FMT, crtc->name, DRM_MODE_ARG(mode));
                          ^
   include/drm/drm_print.h:357:25: note: in definition of macro 
'DRM_DEBUG_DRIVER'
     drm_dbg(DRM_UT_DRIVER, fmt, ##__VA_ARGS__)
                            ^~~
>> drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c:387:2: note: in expansion of macro 
>> 'DBG'
     DBG("%s: set mode: " DMR_MODE_FMT, crtc->name, DRM_MODE_ARG(mode));
     ^~~
>> drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c:387:6: warning: format '%s' 
>> expects a matching 'char *' argument [-Wformat=]
     DBG("%s: set mode: " DMR_MODE_FMT, crtc->name, DRM_MODE_ARG(mode));
         ^
   include/drm/drm_print.h:357:25: note: in definition of macro 
'DRM_DEBUG_DRIVER'
     drm_dbg(DRM_UT_DRIVER, fmt, ##__VA_ARGS__)
                            ^~~
>> drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c:387:2: note: in expansion of macro 
>> 'DBG'
     DBG("%s: set mode: " DMR_MODE_FMT, crtc->name, DRM_MODE_ARG(mode));
     ^~~
--
   In file included from include/drm/drm_crtc.h:40:0,
                    from drivers/gpu/drm/msm/disp/mdp4/mdp4_dsi_encoder.c:20:
   drivers/gpu/drm/msm/disp/mdp4/mdp4_dsi_encoder.c: In function 
'mdp4_dsi_encoder_mode_set':
>> include/drm/drm_modes.h:439:4: error: expected expression before ')' token
     (m)->base.id, (m)->name, (m)->vrefresh, (m)->clock, \
       ^
>> include/drm/drm_print.h:357:32: note: in expansion of macro 'DRM_MODE_ARG'
     drm_dbg(DRM_UT_DRIVER, fmt, ##__VA_ARGS__)
                                   ^~~~~~~~~~~
>> drivers/gpu/drm/msm/msm_drv.h:433:23: note: in expansion of macro 
>> 'DRM_DEBUG_DRIVER'
    #define DBG(fmt, ...) DRM_DEBUG_DRIVER(fmt"\n", ##__VA_ARGS__)
                          ^~~~~~~~~~~~~~~~
>> drivers/gpu/drm/msm/disp/mdp4/mdp4_dsi_encoder.c:61:2: note: in expansion of 
>> macro 'DBG'
     DBG("set mode: " DRM_MODE_FMT, DRM_MODE_ARG()):
     ^~~

vim +387 drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c

   369  
   370  static void mdp5_crtc_mode_set_nofb(struct drm_crtc *crtc)
   371  {
   372          struct mdp5_crtc *mdp5_crtc = to_mdp5_crtc(crtc);
   373          struct mdp5_crtc_state *mdp5_cstate = 
to_mdp5_crtc_state(crtc->state);
   374          struct mdp5_kms *mdp5_kms = get_kms(crtc);
   375          struct mdp5_hw_mixer *mixer = mdp5_cstate->pipeline.mixer;
   376          struct mdp5_hw_mixer *r_mixer = mdp5_cstate->pipeline.r_mixer;
   377          uint32_t lm = mixer->lm;
   378          u32 mixer_width, val;
   379          unsigned long flags;
   380          struct drm_display_mode *mode;
   381  
   382          if (WARN_ON(!crtc->state))
   383                  return;
   384  
   385          mode = &crtc->state->adjusted_mode;
   386  
 > 387          DBG("%s: set mode: " DMR_MODE_FMT, crtc->name, 
 > DRM_MODE_ARG(mode));
   388  
   389          mixer_width = mode->hdisplay;
   390          if (r_mixer)
   391                  mixer_width /= 2;
   392  
   393          spin_lock_irqsave(&mdp5_crtc->lm_lock, flags);
   394          mdp5_write(mdp5_kms, REG_MDP5_LM_OUT_SIZE(lm),
   395                          MDP5_LM_OUT_SIZE_WIDTH(mixer_width) |
   396                          MDP5_LM_OUT_SIZE_HEIGHT(mode->vdisplay));
   397  
   398          /* Assign mixer to LEFT side in source split mode */
   399          val = mdp5_read(mdp5_kms, REG_MDP5_LM_BLEND_COLOR_OUT(lm));
   400          val &= ~MDP5_LM_BLEND_COLOR_OUT_SPLIT_LEFT_RIGHT;
   401          mdp5_write(mdp5_kms, REG_MDP5_LM_BLEND_COLOR_OUT(lm), val);
   402  
   403          if (r_mixer) {
   404                  u32 r_lm = r_mixer->lm;
   405  
   406                  mdp5_write(mdp5_kms, REG_MDP5_LM_OUT_SIZE(r_lm),
   407                             MDP5_LM_OUT_SIZE_WIDTH(mixer_width) |
   408                             MDP5_LM_OUT_SIZE_HEIGHT(mode->vdisplay));
   409  
   410                  /* Assign mixer to RIGHT side in source split mode */
   411                  val = mdp5_read(mdp5_kms, 
REG_MDP5_LM_BLEND_COLOR_OUT(r_lm));
   412                  val |= MDP5_LM_BLEND_COLOR_OUT_SPLIT_LEFT_RIGHT;
   413                  mdp5_write(mdp5_kms, REG_MDP5_LM_BLEND_COLOR_OUT(r_lm), 
val);
   414          }
   415  
   416          spin_unlock_irqrestore(&mdp5_crtc->lm_lock, flags);
   417  }
   418  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Reply via email to