Hi, Bibby:

On Fri, 2018-09-21 at 11:28 +0800, Bibby Hsieh wrote:
> From: chunhui dai <chunhui....@mediatek.com>
> 
> different IC has different clock designed in HDMI, the factor for
> calculate clock should be different. Usinng the data in of_node
> to find this factor.
> 

Reviewed-by: CK Hu <ck...@mediatek.com>

> Signed-off-by: chunhui dai <chunhui....@mediatek.com>
> ---
>  drivers/gpu/drm/mediatek/mtk_dpi.c | 24 +++++++++++++++---------
>  1 file changed, 15 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c 
> b/drivers/gpu/drm/mediatek/mtk_dpi.c
> index 1e7369e0d91c..022ccec49cea 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> @@ -120,6 +120,7 @@ struct mtk_dpi_yc_limit {
>  };
>  
>  struct mtk_dpi_conf {
> +     unsigned int (*cal_factor)(int clock);
>       u32 reg_h_fre_con;
>       bool edge_sel_en;
>  };
> @@ -460,15 +461,7 @@ static int mtk_dpi_set_display_mode(struct mtk_dpi *dpi,
>       unsigned int factor;
>  
>       /* let pll_rate can fix the valid range of tvdpll (1G~2GHz) */
> -
> -     if (mode->clock <= 27000)
> -             factor = 3 << 4;
> -     else if (mode->clock <= 84000)
> -             factor = 3 << 3;
> -     else if (mode->clock <= 167000)
> -             factor = 3 << 2;
> -     else
> -             factor = 3 << 1;
> +     factor = dpi->conf->cal_factor(mode->clock);
>       drm_display_mode_to_videomode(mode, &vm);
>       pll_rate = vm.pixelclock * factor;
>  
> @@ -682,7 +675,20 @@ static const struct component_ops mtk_dpi_component_ops 
> = {
>       .unbind = mtk_dpi_unbind,
>  };
>  
> +static unsigned int mt8173_calculate_factor(int clock)
> +{
> +     if (clock <= 27000)
> +             return 3 << 4;
> +     else if (clock <= 84000)
> +             return 3 << 3;
> +     else if (clock <= 167000)
> +             return 3 << 2;
> +     else
> +             return 3 << 1;
> +}
> +
>  static const struct mtk_dpi_conf mt8173_conf = {
> +     .cal_factor = mt8173_calculate_factor,
>       .reg_h_fre_con = 0xe0,
>  };
>  


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Reply via email to