Quoting Chris Wilson (2018-09-13 20:20:50) > If the ioctl is not supported on a particular piece of HW/driver > combination, report ENOTSUP (aka EOPNOTSUPP) so that it can be easily > distinguished from both the lack of the ioctl and from a regular invalid > parameter. > > v2: Across all the kms ioctls we had a mixture of reporting EINVAL, > ENODEV and a few ENOTSUPP (most where EINVAL) for a failed > drm_core_check_feature(). Update everybody to report ENOTSUPP. > > v3: ENOTSUPP is an internal errno! It's value (524) does not correspond > to a POSIX errno, the one we want is ENOTSUP. However, > uapi/asm-generic/errno.h doesn't include ENOTSUP but man errno says > > "ENOTSUP and EOPNOTSUPP have the same value on Linux, > but according to POSIX.1 these error values should be > distinct." > > so use EOPNOTSUPP as its equivalent. > > Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> > Cc: Daniel Vetter <dan...@ffwll.ch> > Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> > Reviewed-by: Daniel Vetter <daniel.vet...@ffwll.ch> #v2
And pushed to drm-misc-next, so hopefully the ENOTSUP/EOPNOTSUPP is all fine. Thanks for the review, -Chris _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
