On Thu, Jun 21, 2018 at 04:01:16PM -0700, John Stultz wrote:
> The driver doesn't support scaling, but when an atomic test is done
> it repeatedly spits out this warning which isn't particularly useful.
>
> So just remove the error message.
>
> Cc: Xinliang Liu <z.liuxinli...@hisilicon.com>
> Cc: Rongrong Zou <zourongr...@gmail.com>
> Cc: Xinwei Kong <kong.kongxin...@hisilicon.com>
> Cc: Chen Feng <puck.c...@hisilicon.com>
> Cc: David Airlie <airl...@linux.ie>
> Cc: Daniel Vetter <daniel.vet...@ffwll.ch>
> Cc: Peter Griffin <peter.grif...@linaro.org>
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: John Stultz <john.stu...@linaro.org>
Makes sense, applied to drm-misc-next. This code should probably use
drm_atomic_helper_check_plane_state() anyway, which also comes with a
useful set of opt-in debug output to replace this.
-Daniel
> ---
> drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> index 2269be9..bb77420 100644
> --- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> +++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> @@ -859,7 +859,6 @@ static int ade_plane_atomic_check(struct drm_plane *plane,
> return PTR_ERR(crtc_state);
>
> if (src_w != crtc_w || src_h != crtc_h) {
> - DRM_ERROR("Scale not support!!!\n");
> return -EINVAL;
> }
>
> --
> 2.7.4
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
