Hi Christian, I love your patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing] [also build test ERROR on v4.18-rc1 next-20180620] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Christian-K-nig/staging-android-ion-fix-ion_dma_buf_attach-signatur/20180621-044136 config: xtensa-allmodconfig (attached as .config) compiler: xtensa-linux-gcc (GCC) 8.1.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=8.1.0 make.cross ARCH=xtensa All errors (new ones prefixed by >>): >> drivers/staging/android/ion/ion.c:374:12: error: initialization of 'int >> (*)(struct dma_buf *, struct device *, struct dma_buf_attachment *)' from >> incompatible pointer type 'int (*)(struct dma_buf *, struct >> dma_buf_attachment *)' [-Werror=incompatible-pointer-types] .attach = ion_dma_buf_attach, ^~~~~~~~~~~~~~~~~~ drivers/staging/android/ion/ion.c:374:12: note: (near initialization for 'dma_buf_ops.attach') cc1: some warnings being treated as errors vim +374 drivers/staging/android/ion/ion.c b892bf75 Rebecca Schultz Zavin 2013-12-13 368 2328ed66 Bhumika Goyal 2016-10-15 369 static const struct dma_buf_ops dma_buf_ops = { b892bf75 Rebecca Schultz Zavin 2013-12-13 370 .map_dma_buf = ion_map_dma_buf, b892bf75 Rebecca Schultz Zavin 2013-12-13 371 .unmap_dma_buf = ion_unmap_dma_buf, b892bf75 Rebecca Schultz Zavin 2013-12-13 372 .mmap = ion_mmap, b892bf75 Rebecca Schultz Zavin 2013-12-13 373 .release = ion_dma_buf_release, 2a55e7b5 Laura Abbott 2017-04-03 @374 .attach = ion_dma_buf_attach, 2a55e7b5 Laura Abbott 2017-04-03 375 .detach = ion_dma_buf_detatch, 0f34faf8 Rebecca Schultz Zavin 2013-12-13 376 .begin_cpu_access = ion_dma_buf_begin_cpu_access, 0f34faf8 Rebecca Schultz Zavin 2013-12-13 377 .end_cpu_access = ion_dma_buf_end_cpu_access, f9b67f00 Logan Gunthorpe 2017-04-19 378 .map_atomic = ion_dma_buf_kmap, f9b67f00 Logan Gunthorpe 2017-04-19 379 .unmap_atomic = ion_dma_buf_kunmap, f9b67f00 Logan Gunthorpe 2017-04-19 380 .map = ion_dma_buf_kmap, f9b67f00 Logan Gunthorpe 2017-04-19 381 .unmap = ion_dma_buf_kunmap, c30707be Rebecca Schultz Zavin 2013-12-13 382 }; c30707be Rebecca Schultz Zavin 2013-12-13 383 :::::: The code at line 374 was first introduced by commit :::::: 2a55e7b5e5446c970e00be1bca8536f4a58bf21c staging: android: ion: Call dma_map_sg for syncing and mapping :::::: TO: Laura Abbott <labb...@redhat.com> :::::: CC: Greg Kroah-Hartman <gre...@linuxfoundation.org> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
_______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
