On Thu, May 3, 2018 at 3:43 PM, Daniel Vetter <dan...@ffwll.ch> wrote:
> On Thu, May 03, 2018 at 03:40:53PM +0200, Linus Walleij wrote:
>> Commit a30933c27602 ("drm/pl111: Support the Versatile Express")
>> Added a second module using the builtin_platform_driver() call,
>> which works fine as long as you do not try to build the PL111
>> driver as a module, because a module can only have one initcall
>> and cause the following build bug:
>>
>> (...) multiple definition of `init_module' (...)
>>
>> Reported-by: Daniel Vetter <daniel.vet...@ffwll.ch>
>> Cc: Liviu Dudau <liviu.du...@arm.com>
>> Cc: Pawel Moll <pawel.m...@arm.com>
>> Cc: Eric Anholt <e...@anholt.net>
>> Cc: Robin Murphy <robin.mur...@arm.com>
>> Fixes: a30933c27602 ("drm/pl111: Support the Versatile Express")
>> Signed-off-by: Linus Walleij <linus.wall...@linaro.org>
>
> lgtm. Please also reenable the pl111 driver in the drm-rerere branch, you
> can simple revert 17c11b73c2ea6a21eaad5c1f5d358054c9e2c2f6.
>
> Reviewed-by: Daniel Vetter <daniel.vet...@ffwll.ch>Thanks Daniel, hope I can count that Review tag for v2 as well. Will apply and push later tonight unless I have done more mistakes. Yours, Linus Walleij _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
