Hi, On Wed, Feb 28, 2018 at 10:43:30PM +0100, Jernej Škrabec wrote: > Dne sreda, 28. februar 2018 ob 08:36:08 CET je Maxime Ripard napisal(a): > > On Tue, Feb 27, 2018 at 11:26:51PM +0100, Jernej Skrabec wrote: > > > TCON checks for LVDS properties even if it doesn't support it. Add a > > > check to skip that part of the code if TCON doesn't support channel 0. > > > > > > Signed-off-by: Jernej Skrabec <jernej.skra...@siol.net> > > > > I have already sent a similar patch here: > > https://lists.freedesktop.org/archives/dri-devel/2018-February/166665.html > > Right. However, check last chunk in my patch. There is no need to call > sun4i_rgb_init() if TCON doesn't support channel 0. It doesn't do anything, > except producing warning. Will you add that this change to your patch and > then > I can remove this patch from next revision?
They are orthogonal to me though. Mine fixes the spurious LVDS error messages that you were mentionning in your commit log. Your point here is that we shouldn't need to even register the LVDS and RGB output when there's no channel 0. This is obviously true, but it should be in a separate patch. > BTW, your patch won't apply cleanly, since you didn't base it on latest code > (every TCON variant has at least one entry now). I'll fix it when applying. Maxime -- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com
signature.asc
Description: PGP signature
_______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
