On Mon, Jan 15, 2018 at 05:57:04PM -0800, Hyun Kwon wrote:
> The dt binding for Xilinx display pipeline. The pipeline can be
> composed with multiple and different types of sub-devices. This node
> is to represent the entire pipeline as a single entity.
>
> Signed-off-by: Hyun Kwon <hyun.k...@xilinx.com>
> ---
> v2
> - Remove linux specific terms
> - Elaborate details, ex regarding port binding
> - Rename xlnx,kms to xlnx,display
> - Rename the file name to xlnx,display.txt
> - Add examples of hardware blocks
> ---
> ---
> .../bindings/display/xlnx/xlnx,display.txt | 68
> ++++++++++++++++++++++
> 1 file changed, 68 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/display/xlnx/xlnx,display.txt
>
> diff --git a/Documentation/devicetree/bindings/display/xlnx/xlnx,display.txt
> b/Documentation/devicetree/bindings/display/xlnx/xlnx,display.txt
> new file mode 100644
> index 0000000..fde1a35
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/xlnx/xlnx,display.txt
> @@ -0,0 +1,68 @@
> +Xilinx Display Pipeline
> +-----------------------
> +
> +Xilinx display pipeline can be designed with various types of multiple IPs:
> +IPs hardened on chip, ob board IPs, and soft IPs in programmable logic.
s/ob board/on-board/
> +While each component would need its own node, this node represents
> +a whole display pipeline as a single entity by integrating individual
> subdevice
> +with glue logics.
> +
> +The following illustrates some examples of topology:
> +
> +A linear pipeline with multiple blocks:
> +
> + SoC DMA -> SoC display controller -> SoC display enc
> +or,
> + FPGA DMA -> FPGA display controller -> FPGA display enc
> +
> +A pipeline with branches:
> +
> + SoC DMA -> SoC display controller -> SoC display enc
> + |
> + FPGA DMA->
> +or,
> + SoC DMA -> SoC display controller -> SoC display enc
> + |
> + -> FPAG display enc
s/FPAG/FPGA/
> +
> +or,
> +
> + SoC DMA -> SoC display controller -> SoC display enc
> + | |
> + FPGA display controller -> -> FPGA display enc
> +
> +Required properties:
> +
> +- compatible: Must be "xlnx,display".
> +
> +- ports: phandles for ports of display controller subdevice.
> + In the display controller port nodes, topology for entire pipeline
> + should be described using the DT bindings defined in
> + Documentation/devicetree/bindings/graph.txt.
> +
> +Example:
> +
> + xlnx_display {
> + compatible = "xlnx,display";
> + ports = <&display_controller_port>;
I still don't think you need this node. Match the DRM driver with the
display controller node.
> + };
> +
> + display_controller {
display-controller@???
Please show at least the compatible and reg in the example.
> + ...
> + display_controller_port: port@0 {
Unit address is not needed here. If you have a unit address, then you
should have a reg property (and #size-cells and #address-cells in the
parent).
> + display_controller_ep: endpoint {
> + remote-endpoint = <&dp_controller_ep>;
> + };
> + };
> + ...
> + };
> +
> + dp_controller {
> + ...
> + dp_controller_port: port@0 {
> + dp_controller_ep: endpoint {
> + remote-endpoint = <&display_controller_ep>;
> + };
> + };
> + ...
> + };
> --
> 2.7.4
>
> This email and any attachments are intended for the sole use of the named
> recipient(s) and contain(s) confidential information that may be proprietary,
> privileged or copyrighted under applicable law. If you are not the intended
> recipient, do not read, copy, or forward this email message or any
> attachments. Delete this email message and any attachments immediately.
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
