On Thu, Mar 29, 2012 at 18:28, Paulo Zanoni <przan...@gmail.com> wrote:
> From: Paulo Zanoni <paulo.r.zan...@intel.com> > > Use unsigned int instead of int: > - modetest.c:89:1: warning: comparison between signed and unsigned integer > expressions [-Wsign-compare] > - modetest.c:97:1: warning: comparison between signed and unsigned integer > expressions [-Wsign-compare] > - modetest.c:117:1: warning: comparison between signed and unsigned > integer expressions [-Wsign-compare] > - modetest.c:772:16: warning: comparison between signed and unsigned > integer expressions [-Wsign-compare] > > The 'fd' variable is global, we don't need to pass it as an argument: > - modetest.c:698:40: warning: unused parameter ‘fd’ [-Wunused-parameter] > > We don't use the 'modeset' variable: > - modetest.c:725:8: warning: variable ‘modeset’ set but not used > [-Wunused-but-set-variable] > This one is: Reviewed-by: Eugeni Dodonov <eugeni.dodo...@intel.com> -static int page_flipping_supported(int fd) > +static int page_flipping_supported(void) > I wonder if we could drop the dead^W#ifd 0'ed code here as well, perhaps with a separate patch? I don't think it will get used again in the future (but I might be wrong). -- Eugeni Dodonov <http://eugeni.dodonov.net/>
_______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
