On Wed, Nov 8, 2017 at 11:35 AM, Alex Deucher <alexdeuc...@gmail.com> wrote:
> On Wed, Nov 8, 2017 at 2:30 PM, Guenter Roeck <gro...@google.com> wrote: > > On Wed, Nov 8, 2017 at 11:18 AM, Deucher, Alexander > > <alexander.deuc...@amd.com> wrote: > >> > >> > -----Original Message----- > >> > From: Mark Brown [mailto:broo...@kernel.org] > >> > Sent: Wednesday, November 08, 2017 1:48 PM > >> > To: Alex Deucher > >> > Cc: amd-gfx list; alsa-de...@alsa-project.org; Maling list - DRI > >> > developers; > >> > Mukunda, Vijendar; Liam Girdwood; Takashi Iwai; Guenter Roeck; > Deucher, > >> > Alexander > >> > Subject: Re: [PATCH] ASoC: amd: fix report accurate hw_ptr during dma > >> > > >> > On Wed, Nov 08, 2017 at 01:40:32PM -0500, Alex Deucher wrote: > >> > > On Wed, Nov 8, 2017 at 1:22 PM, Mark Brown <broo...@kernel.org> > >> > wrote: > >> > > >> > > > Like I said in reply to your other mail please don't resubmit > >> > > > already > >> > > > applied patches. The current tip of my topic/amd branch appears > to > >> > > > be > >> > > > this very patch, if there's anything needs changing please send an > >> > > > incremental patch. > >> > > >> > > I'm not seeing this one in your tree either. This is just a resend > of > >> > > Guenter's patch from an hour ago with the chromium stuff removed. > >> > > Maybe you already applied it in the interim? > >> > > >> > Is this different to "ASoC: amd: Report accurate hw_ptr during dma" > >> > which was applied at 16:07? > >> > >> Yes, this is a fix for that patch. It fixes a 64 bit division that > wasn't > >> properly handled. > >> > > > > In that case, the subject should reflect the problem fixed, the > description > > should describe the problem, and there should be a Fixes: tag pointing to > > the problematic patch. > > I updated the patch subject and added a fixes tag when I resent it > after removing the chrome tags. The subject could have been bit > better, but I wasn't sure how far to take it since it wasn't my patch > originally. > > In such situations, it is probably better to write a new patch with proper subject and description and add a tag such as "Reported-by:", "Suggested-by:", or "Originally-from:" to give some credit if you feel generous. The attempt to retain my ownership caused way more trouble than it is worth. Guenter > Alex > > > > > Sorry, I was not aware that the problematic patch is already pending > > upstream, or I would have submitted a proper patch upstream myself. > > > > Guenter > > > >> > >> Alex > >> > > >
_______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
