The kzalloc function returns a void pointer and the assignment
operator converts it to the type of pointer it is assigned to.
Therefore, there is no need to cast.

Issue found by alloc_cast.cocci:
* WARNING: casting value returned by memory allocation function
to <struct type> is useless.

Path to the cocci script: scripts/coccinelle/api/alloc/alloc_cast.cocci

Signed-off-by: Georgiana Chelu <georgiana.chel...@gmail.com>
---

Changes in v2:
* adjusted the subject prefix of the patches
* added the cocci script used to generate the patches

 .../amd/powerplay/hwmgr/vega10_processpptables.c   | 24 ++++++++--------------
 1 file changed, 8 insertions(+), 16 deletions(-)

diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_processpptables.c 
b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_processpptables.c
index e343df190375..d968c3834481 100644
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_processpptables.c
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_processpptables.c
@@ -291,8 +291,7 @@ static int get_mm_clock_voltage_table(
        table_size = sizeof(uint32_t) +
                        sizeof(phm_ppt_v1_mm_clock_voltage_dependency_record) *
                        mm_dependency_table->ucNumEntries;
-       mm_table = (phm_ppt_v1_mm_clock_voltage_dependency_table *)
-                       kzalloc(table_size, GFP_KERNEL);
+       mm_table = kzalloc(table_size, GFP_KERNEL);
 
        if (!mm_table)
                return -ENOMEM;
@@ -519,8 +518,7 @@ static int get_socclk_voltage_dependency_table(
                        sizeof(phm_ppt_v1_clock_voltage_dependency_record) *
                        clk_dep_table->ucNumEntries;
 
-       clk_table = (phm_ppt_v1_clock_voltage_dependency_table *)
-                       kzalloc(table_size, GFP_KERNEL);
+       clk_table = kzalloc(table_size, GFP_KERNEL);
 
        if (!clk_table)
                return -ENOMEM;
@@ -554,8 +552,7 @@ static int get_mclk_voltage_dependency_table(
                        sizeof(phm_ppt_v1_clock_voltage_dependency_record) *
                        mclk_dep_table->ucNumEntries;
 
-       mclk_table = (phm_ppt_v1_clock_voltage_dependency_table *)
-                       kzalloc(table_size, GFP_KERNEL);
+       mclk_table = kzalloc(table_size, GFP_KERNEL);
 
        if (!mclk_table)
                return -ENOMEM;
@@ -596,8 +593,7 @@ static int get_gfxclk_voltage_dependency_table(
                        sizeof(phm_ppt_v1_clock_voltage_dependency_record) *
                        clk_dep_table->ucNumEntries;
 
-       clk_table = (struct phm_ppt_v1_clock_voltage_dependency_table *)
-                       kzalloc(table_size, GFP_KERNEL);
+       clk_table = kzalloc(table_size, GFP_KERNEL);
 
        if (!clk_table)
                return -ENOMEM;
@@ -663,8 +659,7 @@ static int get_pix_clk_voltage_dependency_table(
                        sizeof(phm_ppt_v1_clock_voltage_dependency_record) *
                        clk_dep_table->ucNumEntries;
 
-       clk_table = (struct phm_ppt_v1_clock_voltage_dependency_table *)
-                       kzalloc(table_size, GFP_KERNEL);
+       clk_table = kzalloc(table_size, GFP_KERNEL);
 
        if (!clk_table)
                return -ENOMEM;
@@ -728,8 +723,7 @@ static int get_dcefclk_voltage_dependency_table(
                        sizeof(phm_ppt_v1_clock_voltage_dependency_record) *
                        num_entries;
 
-       clk_table = (struct phm_ppt_v1_clock_voltage_dependency_table *)
-                       kzalloc(table_size, GFP_KERNEL);
+       clk_table = kzalloc(table_size, GFP_KERNEL);
 
        if (!clk_table)
                return -ENOMEM;
@@ -772,8 +766,7 @@ static int get_pcie_table(struct pp_hwmgr *hwmgr,
                        sizeof(struct phm_ppt_v1_pcie_record) *
                        atom_pcie_table->ucNumEntries;
 
-       pcie_table = (struct phm_ppt_v1_pcie_table *)
-                       kzalloc(table_size, GFP_KERNEL);
+       pcie_table = kzalloc(table_size, GFP_KERNEL);
 
        if (!pcie_table)
                return -ENOMEM;
@@ -1026,8 +1019,7 @@ static int get_vddc_lookup_table(
        table_size = sizeof(uint32_t) +
                        sizeof(phm_ppt_v1_voltage_lookup_record) * max_levels;
 
-       table = (phm_ppt_v1_voltage_lookup_table *)
-                       kzalloc(table_size, GFP_KERNEL);
+       table = kzalloc(table_size, GFP_KERNEL);
 
        if (NULL == table)
                return -ENOMEM;
-- 
2.11.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Reply via email to