On Tue, Oct 10, 2017 at 2:42 PM, Aishwarya Pant <aishp...@gmail.com> wrote: > pipe is an unsigned int and less than zero comparison for unsigned > values is always false. > > Detected using the following cocci script: > > @@ > unsigned int i; > @@ > * i < 0 >
Thanks Reviewed-by: Rob Clark <robdcl...@gmail.com> > Signed-off-by: Aishwarya Pant <aishp...@gmail.com> > --- > drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c > b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c > index f7c0698fec40..7e829a8d1cb1 100644 > --- a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c > +++ b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c > @@ -599,7 +599,7 @@ static u32 mdp5_get_vblank_counter(struct drm_device > *dev, unsigned int pipe) > struct drm_crtc *crtc; > struct drm_encoder *encoder; > > - if (pipe < 0 || pipe >= priv->num_crtcs) > + if (pipe >= priv->num_crtcs) > return 0; > > crtc = priv->crtcs[pipe]; > -- > 2.11.0 > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
