If the wait_status() fails either because of an error reported in the
STATUS register or because of a timeout waiting for the wait_mask, print
information which might help diagnose the reason.

Signed-off-by: Peter Ujfalusi <peter.ujfal...@ti.com>
---
 drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c 
b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
index 1dd3dafc59af..5a18f0ead4d5 100644
--- a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
+++ b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
@@ -121,14 +121,22 @@ static int wait_status(struct refill_engine *engine, 
uint32_t wait_mask)
        while (true) {
                r = dmm_read(dmm, reg[PAT_STATUS][engine->id]);
                err = r & DMM_PATSTATUS_ERR;
-               if (err)
+               if (err) {
+                       dev_err(dmm->dev,
+                               "%s: error (engine%d). PAT_STATUS: 0x%08x\n",
+                               __func__, engine->id, r);
                        return -EFAULT;
+               }
 
                if ((r & wait_mask) == wait_mask)
                        break;
 
-               if (--i == 0)
+               if (--i == 0) {
+                       dev_err(dmm->dev,
+                               "%s: timeout (engine%d). PAT_STATUS: 0x%08x\n",
+                               __func__, engine->id, r);
                        return -ETIMEDOUT;
+               }
 
                udelay(1);
        }
-- 
2.14.1


Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. 
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Reply via email to