Hi,
On 15 August 2017 at 22:14, Peter Griffin <peter.grif...@linaro.org> wrote:
> This patch fixes the following soft lockup:
> BUG: soft lockup - CPU#0 stuck for 23s! [weston:307]
>
> On weston idle-timeout the IP is powered down and reset
> asserted. On weston resume we get a massive vblank
> IRQ storm due to the LDI registers having lost some state.
>
> This state loss is caused by ade_crtc_atomic_begin() not
> calling ade_ldi_set_mode(). With this patch applied
> resuming from Weston idle-timeout works well.
>
> Signed-off-by: Peter Griffin <peter.grif...@linaro.org>
> Tested-by: John Stultz <john.stu...@linaro.org>
>
Thanks Peter,
This patch looks good to me.
Reviewed-by: Xinliang Liu <xinliang....@linaro.org>
@Sean, could you please help to apply to drm-misc if others has no more
comments, thanks.
Thanks,
Xinliang
> Cc: sta...@vger.kernel.org
> ---
> drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> index c96c228..72c6357 100644
> --- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> +++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> @@ -519,9 +519,12 @@ static void ade_crtc_atomic_begin(struct drm_crtc
> *crtc,
> {
> struct ade_crtc *acrtc = to_ade_crtc(crtc);
> struct ade_hw_ctx *ctx = acrtc->ctx;
> + struct drm_display_mode *mode = &crtc->state->mode;
> + struct drm_display_mode *adj_mode = &crtc->state->adjusted_mode;
>
> if (!ctx->power_on)
> (void)ade_power_up(ctx);
> + ade_ldi_set_mode(acrtc, mode, adj_mode);
> }
>
> static void ade_crtc_atomic_flush(struct drm_crtc *crtc,
> --
> 2.7.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
