On Fri, May 26, 2017 at 12:58:55PM +0300, Jani Nikula wrote: > On Thu, 25 May 2017, "Du, Changbin" <changbin...@intel.com> wrote: > >> Note: > >> select should be used with care. select will force > >> a symbol to a value without visiting the dependencies. > >> By abusing select you are able to select a symbol FOO even > >> if FOO depends on BAR that is not set. > >> In general use select only for non-visible symbols > >> (no prompts anywhere) and for symbols with no dependencies. > >> That will limit the usefulness but on the other hand avoid > >> the illegal configurations all over. > >> > > Yes, we should always be carefull with 'select' and should not use it if > > possible. So here I must create a 'menu' to ensure its safety. > > I'm trying to say, why do you make DRM_I915_GVT visible in menuconfig at > all when you can't actually change it in menuconfig? > ok, that is to info the user that GVT is enabled, since DRM_I915_GVT apply to seperated i915 module. I saw similar behaviour in some driver, but cannot recall its name now...
> BR, > Jani. > > > > > > >> BR, > >> Jani. > >> > >> > Choose this option if you want to enable Intel GVT-g graphics > >> > virtualization technology host support with integrated > >> > graphics. > >> > With GVT-g, it's possible to have one integrated graphics > >> > @@ -116,13 +119,14 @@ config DRM_I915_GVT > >> > > >> > config DRM_I915_GVT_KVMGT > >> > tristate "Enable KVM/VFIO support for Intel GVT-g" > >> > - depends on DRM_I915_GVT > >> > + select DRM_I915_GVT > >> > depends on KVM > >> > depends on VFIO_MDEV && VFIO_MDEV_DEVICE > >> > default n > >> > help > >> > Choose this option if you want to enable KVMGT support for > >> > Intel GVT-g. > >> > +endmenu > >> > > >> > menu "drm/i915 Debugging" > >> > depends on DRM_I915 > >> > >> -- > >> Jani Nikula, Intel Open Source Technology Center > >> _______________________________________________ > >> intel-gvt-dev mailing list > >> intel-gvt-...@lists.freedesktop.org > >> https://lists.freedesktop.org/mailman/listinfo/intel-gvt-dev > > -- > Jani Nikula, Intel Open Source Technology Center -- Thanks, Changbin Du
signature.asc
Description: PGP signature
_______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
