Adam Jackson <a...@redhat.com> writes: > drmCompareBusInfo was almost this already, but it wasn't exported, its > name didn't match its functionality, and while it almost looks like it > was usable for sorting due to memcmp it wouldn't work if you had > multiple bus types. I don't really want to think about defining a > sensible sort order for bus types, so let's at least make it less of a > trap for the caller. > > Invert its boolean sense to be 'true if equal', rename it to describe > the type it actually operates on, and export.
I love flipping the comparison, but my only request would be to name it drmDevicesEqual() instead, as Compare sounds a bit like memcmp() to me. With that changed, Reviewed-by: Eric Anholt <e...@anholt.net>
signature.asc
Description: PGP signature
_______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
