On ti, 2017-01-10 at 14:40 +0000, Chris Wilson wrote:
> Â Â Â Â Â Â Â Â drivers/gpu/drm/selftests/test-drm_mm.c:1277
> evict_everything()
> Â Â Â Â Â Â Â Â warn: calling list_del() inside list_for_each
>
> The list_del() inside the error handling in the eviction loop is
> overkill. We have to undo the eviction scan to return the drm_mm back to
> a recoverable state, so have to iterate over the full list, but we only
> want to report the error once and once we have an error we can return
> early.
>
> Reported-by: Dan Carpenter <dan.carpenter at oracle.com>
> Fixes: 560b32842912 ("drm: kselftest for drm_mm and eviction")
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
Ah, as mentioned previously, we soon need tests for the selftests :)
Reviewed-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
