On Thu, Sep 29, 2016 at 11:58 PM, Marek Vasut <marex at denx.de> wrote: > + /** > + * @prepare_fb: > + * > + * Optional, called by struct &drm_plane_helper_funcs ->prepare_fb . > + */
You've lost the hint that people should look there for what this hook should do. Same with cleanup_fb. I think that was useful, can you pls reinsert it? Just something like "Please read the documentation for the ->prepare_fb hook in &drm_plane_helper_funcs for more details." Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch