On Mon, Sep 19, 2016 at 04:33:45PM +0300, ville.syrjala at linux.intel.com wrote: > From: Ville Syrjälä <ville.syrjala at linux.intel.com> > > drm/arm/malidp_planes.c:49:24: warning: symbol 'malidp_duplicate_plane_state' > was not declared. Should it be static? > drm/arm/malidp_planes.c:66:6: warning: symbol 'malidp_destroy_plane_state' > was not declared. Should it be static? > > Cc: Liviu Dudau <Liviu.Dudau at arm.com>
Acked-by: Liviu Dudau <Liviu.Dudau at arm.com> Thanks for cleaning it up! Liviu > Cc: Brian Starkey <brian.starkey at arm.com> > Cc: Mali DP Maintainers <malidp at foss.arm.com> > Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com> > --- > drivers/gpu/drm/arm/malidp_planes.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/arm/malidp_planes.c > b/drivers/gpu/drm/arm/malidp_planes.c > index 82c193e5e0d6..cc9b8e02904d 100644 > --- a/drivers/gpu/drm/arm/malidp_planes.c > +++ b/drivers/gpu/drm/arm/malidp_planes.c > @@ -46,7 +46,7 @@ static void malidp_de_plane_destroy(struct drm_plane *plane) > devm_kfree(plane->dev->dev, mp); > } > > -struct drm_plane_state *malidp_duplicate_plane_state(struct drm_plane *plane) > +static struct drm_plane_state *malidp_duplicate_plane_state(struct drm_plane > *plane) > { > struct malidp_plane_state *state, *m_state; > > @@ -63,8 +63,8 @@ struct drm_plane_state *malidp_duplicate_plane_state(struct > drm_plane *plane) > return &state->base; > } > > -void malidp_destroy_plane_state(struct drm_plane *plane, > - struct drm_plane_state *state) > +static void malidp_destroy_plane_state(struct drm_plane *plane, > + struct drm_plane_state *state) > { > struct malidp_plane_state *m_state = to_malidp_plane_state(state); > > -- > 2.7.4 > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ã)_/¯