On Wed, 2016-08-31 at 18:09 +0200, Daniel Vetter wrote:
> Now that there's less stuff in there I noticed that I overlooked
> them.
> Sprinkle some docs over them while at it.
>
> Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
> ---
>  include/drm/drm_connector.h   | 24 ++++++++++++++++++++++--
>  include/drm/drm_crtc.h        | 32 --------------------------------
>  include/drm/drm_encoder.h     | 22 ++++++++++++++++++++++
> Â include/drm/drm_framebuffer.h | 17 +++++++++++++++++
>  include/drm/drm_modes.h       |  2 ++
>  include/drm/drm_property.h    |  1 +
> Â 6 files changed, 64 insertions(+), 34 deletions(-)
>
> diff --git a/include/drm/drm_connector.h
> b/include/drm/drm_connector.h
> index 66b7d6744dd2..e4e545e9516d 100644
> --- a/include/drm/drm_connector.h
> +++ b/include/drm/drm_connector.h
> @@ -181,14 +181,19 @@ int drm_display_info_set_bus_formats(struct
> drm_display_info *info,
> Â /**
> Â * struct drm_connector_state - mutable connector state
> Â * @connector: backpointer to the connector
> - * @crtc: CRTC to connect connector to, NULL if disabled
> Â * @best_encoder: can be used by helpers and drivers to select the
> encoder
> Â * @state: backpointer to global drm_atomic_state
> Â */
> Â struct drm_connector_state {
> Â struct drm_connector *connector;
> Â
> - struct drm_crtc *crtc;Â Â /* do not write directly, use
> drm_atomic_set_crtc_for_connector() */
> + /**
> + Â * @crtc: CRTC to connect connector to, NULL if disabled.
> + Â *
> + Â * Do not change this directly, use
> drm_atomic_set_crtc_for_connector()
> + Â * instead.
> + Â */
> + struct drm_crtc *crtc;
> Â
> Â struct drm_encoder *best_encoder;
> Â
> @@ -744,4 +749,19 @@ int drm_mode_connector_set_path_property(struct
> drm_connector *connector,
> Â int drm_mode_connector_set_tile_property(struct drm_connector
> *connector);
> Â int drm_mode_connector_update_edid_property(struct drm_connector
> *connector,
> Â Â Â Â Â const struct edid
> *edid);
> +
> +/**
> + * drm_for_each_connector - iterate over all connectors
> + * @connector: the loop cursor
> + * @dev: the DRM device
> + *
> + * Iterate over all connectors of @dev.
> + */
> +#define drm_for_each_connector(connector, dev) \
> + for (assert_drm_connector_list_read_locked(&(dev)-
> >mode_config), \
> + Â Â Â Â Â connector = list_first_entry(&(dev)-
> >mode_config.connector_list, \
> + Â Â struct drm_connector,
> head); \
> + Â Â Â Â Â &connector->head != (&(dev)-
> >mode_config.connector_list); \
> + Â Â Â Â Â connector = list_next_entry(connector, head))
> +
> Â #endif
> diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h
> index 4880606e2ffd..2a642ae96127 100644
> --- a/include/drm/drm_crtc.h
> +++ b/include/drm/drm_crtc.h
> @@ -1991,22 +1991,7 @@ struct drm_mode_config {
> Â list_for_each_entry((plane), &(dev)->mode_config.plane_list,
> head) \
> Â for_each_if ((plane_mask) & (1 <<
> drm_plane_index(plane)))
> Â
> -/**
> - * drm_for_each_encoder_mask - iterate over encoders specified by
> bitmask
> - * @encoder: the loop cursor
> - * @dev: the DRM device
> - * @encoder_mask: bitmask of encoder indices
> - *
> - * Iterate over all encoders specified by bitmask.
> - */
> -#define drm_for_each_encoder_mask(encoder, dev, encoder_mask) \
> - list_for_each_entry((encoder), &(dev)-
> >mode_config.encoder_list, head) \
> - for_each_if ((encoder_mask) & (1 <<
> drm_encoder_index(encoder)))
> -
> Â #define obj_to_crtc(x) container_of(x, struct drm_crtc, base)
> -#define obj_to_mode(x) container_of(x, struct drm_display_mode,
> base)
> -#define obj_to_fb(x) container_of(x, struct drm_framebuffer, base)
> -#define obj_to_blob(x) container_of(x, struct drm_property_blob,
> base)
> Â #define obj_to_plane(x) container_of(x, struct drm_plane, base)
> Â
> Â extern __printf(6, 7)
> @@ -2174,23 +2159,6 @@ assert_drm_connector_list_read_locked(struct
> drm_mode_config *mode_config)
> Â !drm_modeset_is_locked(&mode_config-
> >connection_mutex));
> Â }
> Â
> -#define drm_for_each_connector(connector, dev) \
> - for (assert_drm_connector_list_read_locked(&(dev)-
> >mode_config), \
> - Â Â Â Â Â connector = list_first_entry(&(dev)-
> >mode_config.connector_list, \
> - Â Â struct drm_connector,
> head); \
> - Â Â Â Â Â &connector->head != (&(dev)-
> >mode_config.connector_list); \
> - Â Â Â Â Â connector = list_next_entry(connector, head))
> -
> -#define drm_for_each_encoder(encoder, dev) \
> - list_for_each_entry(encoder, &(dev)-
> >mode_config.encoder_list, head)
> -
> -#define drm_for_each_fb(fb, dev) \
> - for (WARN_ON(!mutex_is_locked(&(dev)->mode_config.fb_lock)),
> \
> - Â Â Â Â Â fb = list_first_entry(&(dev)->mode_config.fb_list,
> \
> - Â Â struct drm_framebuffer,
> head); \
> - Â Â Â Â Â &fb->head != (&(dev)->mode_config.fb_list);
> \
> - Â Â Â Â Â fb = list_next_entry(fb, head))
> -
> Â /* drm_edid.c */
> Â bool drm_probe_ddc(struct i2c_adapter *adapter);
> Â struct edid *drm_get_edid(struct drm_connector *connector,
> diff --git a/include/drm/drm_encoder.h b/include/drm/drm_encoder.h
> index fce0203094f7..387e33a4d6ee 100644
> --- a/include/drm/drm_encoder.h
> +++ b/include/drm/drm_encoder.h
> @@ -224,4 +224,26 @@ static inline struct drm_encoder
> *drm_encoder_find(struct drm_device *dev,
> Â
> Â void drm_encoder_cleanup(struct drm_encoder *encoder);
> Â
> +/**
> + * drm_for_each_encoder_mask - iterate over encoders specified by
> bitmask
> + * @encoder: the loop cursor
> + * @dev: the DRM device
> + * @encoder_mask: bitmask of encoder indices
> + *
> + * Iterate over all encoders specified by bitmask.
> + */
> +#define drm_for_each_encoder_mask(encoder, dev, encoder_mask) \
> + list_for_each_entry((encoder), &(dev)-
> >mode_config.encoder_list, head) \
> + for_each_if ((encoder_mask) & (1 <<
> drm_encoder_index(encoder)))
I know this is code movement for now but getting rid of the blank space
above in the "for_each_if ((" makes 1 Error and 1 Warning go away from
the checkpatch script
> +
> +/**
> + * drm_for_each_encoder - iterate over all encoders
> + * @encoder: the loop cursor
> + * @dev: the DRM device
> + *
> + * Iterate over all encoders of @dev.
> + */
> +#define drm_for_each_encoder(encoder, dev) \
> + list_for_each_entry(encoder, &(dev)-
> >mode_config.encoder_list, head)
> +
> Â #endif
> diff --git a/include/drm/drm_framebuffer.h
> b/include/drm/drm_framebuffer.h
> index b2554c50a903..f5ae1f436a4b 100644
> --- a/include/drm/drm_framebuffer.h
> +++ b/include/drm/drm_framebuffer.h
> @@ -206,6 +206,8 @@ struct drm_framebuffer {
> Â struct list_head filp_head;
> Â };
> Â
> +#define obj_to_fb(x) container_of(x, struct drm_framebuffer, base)
> +
> Â int drm_framebuffer_init(struct drm_device *dev,
> Â Â struct drm_framebuffer *fb,
> Â Â const struct drm_framebuffer_funcs *funcs);
> @@ -247,4 +249,19 @@ static inline uint32_t
> drm_framebuffer_read_refcount(struct drm_framebuffer *fb)
> Â {
> Â return atomic_read(&fb->base.refcount.refcount);
> Â }
> +
> +/**
> + * drm_for_each_fb - iterate over all framebuffers
> + * @fb: the loop cursor
> + * @dev: the DRM device
> + *
> + * Iterate over all framebuffers of @dev. User must hold the fb_lock
> from
> + * &drm_mode_config.
> + */
> +#define drm_for_each_fb(fb, dev) \
> + for (WARN_ON(!mutex_is_locked(&(dev)->mode_config.fb_lock)),
> \
> + Â Â Â Â Â fb = list_first_entry(&(dev)->mode_config.fb_list,
> \
> + Â Â struct drm_framebuffer,
> head); \
> + Â Â Â Â Â &fb->head != (&(dev)->mode_config.fb_list);
> \
> + Â Â Â Â Â fb = list_next_entry(fb, head))
> Â #endif
> diff --git a/include/drm/drm_modes.h b/include/drm/drm_modes.h
> index 011f199d3bcf..986ed6ff635a 100644
> --- a/include/drm/drm_modes.h
> +++ b/include/drm/drm_modes.h
> @@ -403,6 +403,8 @@ struct drm_display_mode {
> Â enum hdmi_picture_aspect picture_aspect_ratio;
> Â };
> Â
> +#define obj_to_mode(x) container_of(x, struct drm_display_mode,
> base)
> +
> Â /**
> Â * drm_mode_is_stereo - check for stereo mode flags
> Â * @mode: drm_display_mode to check
> diff --git a/include/drm/drm_property.h b/include/drm/drm_property.h
> index 30ab289be05d..43c4b6a2046d 100644
> --- a/include/drm/drm_property.h
> +++ b/include/drm/drm_property.h
> @@ -219,6 +219,7 @@ struct drm_prop_enum_list {
> Â };
> Â
> Â #define obj_to_property(x) container_of(x, struct drm_property,
> base)
> +#define obj_to_blob(x) container_of(x, struct drm_property_blob,
> base)
> Â
> Â /**
> Â * drm_property_type_is - check the type of a property
thanks,
Carlos Santa
