Right. The goof is a consequence of me doing copy-and-paste style edits. I first added powers-of-two benchmark which intentionally start from index 1 but and then copied and edited that into comon-modes benchmark, and missed to correct the starting index of the loop.

Reviewed-by: Ilija Hadzic <ihad...@research.bell-labs.com>



On Wed, 7 Dec 2011 ch...@lemote.com wrote:

From: Chen Jie <ch...@lemote.com>

Sweep common_modes array should start with index 0.

Signed-off-by: Chen Jie <ch...@lemote.com>
---
drivers/gpu/drm/radeon/radeon_benchmark.c |    6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/radeon/radeon_benchmark.c 
b/drivers/gpu/drm/radeon/radeon_benchmark.c
index 17e1a9b..d1cea8d 100644
--- a/drivers/gpu/drm/radeon/radeon_benchmark.c
+++ b/drivers/gpu/drm/radeon/radeon_benchmark.c
@@ -229,21 +229,21 @@ void radeon_benchmark(struct radeon_device *rdev, int 
test_number)
                break;
        case 6:
                /* GTT to VRAM, buffer size sweep, common modes */
-               for (i = 1; i < RADEON_BENCHMARK_COMMON_MODES_N; i++)
+               for (i = 0; i < RADEON_BENCHMARK_COMMON_MODES_N; i++)
                        radeon_benchmark_move(rdev, common_modes[i],
                                              RADEON_GEM_DOMAIN_GTT,
                                              RADEON_GEM_DOMAIN_VRAM);
                break;
        case 7:
                /* VRAM to GTT, buffer size sweep, common modes */
-               for (i = 1; i < RADEON_BENCHMARK_COMMON_MODES_N; i++)
+               for (i = 0; i < RADEON_BENCHMARK_COMMON_MODES_N; i++)
                        radeon_benchmark_move(rdev, common_modes[i],
                                              RADEON_GEM_DOMAIN_VRAM,
                                              RADEON_GEM_DOMAIN_GTT);
                break;
        case 8:
                /* VRAM to VRAM, buffer size sweep, common modes */
-               for (i = 1; i < RADEON_BENCHMARK_COMMON_MODES_N; i++)
+               for (i = 0; i < RADEON_BENCHMARK_COMMON_MODES_N; i++)
                        radeon_benchmark_move(rdev, common_modes[i],
                                              RADEON_GEM_DOMAIN_VRAM,
                                              RADEON_GEM_DOMAIN_VRAM);
--
1.7.7.3

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Reply via email to