On 24 October 2016 at 23:43, Karol Herbst <karolherbst at gmail.com> wrote:
> 2016-10-24 9:13 GMT+02:00 Baoyou Xie <baoyou.xie at linaro.org>: > > > > > > On 23 October 2016 at 01:32, Karol Herbst <karolherbst at gmail.com> wrote: > >> > >> I think it would be better to squash those commits: > >> 1. for the includes > >> 2. for static declerations > >> > > OK, I have resent new patch that squash those commits. > > > > thanks, this is much easier to review and keeps the git history clean :) > Will try to make a test with those patches over the next days, but it > looks fine as it is already. > > I worked them out on next-20161021. > >> > >> 2016-10-22 11:41 GMT+02:00 Baoyou Xie <baoyou.xie at linaro.org>: > >> > We get 2 warnings when building kernel with W=1: > >> > drivers/gpu/drm/nouveau/nvkm/core/firmware.c:34:1: warning: no > previous > >> > prototype for 'nvkm_firmware_get' [-Wmissing-prototypes] > >> > drivers/gpu/drm/nouveau/nvkm/core/firmware.c:58:1: warning: no > previous > >> > prototype for 'nvkm_firmware_put' [-Wmissing-prototypes] > >> > > >> > In fact, these functions are declared in > >> > drivers/gpu/drm/nouveau/include/nvkm/core/firmware.h. > >> > So this patch adds missing header dependencies. > >> > > >> > Signed-off-by: Baoyou Xie <baoyou.xie at linaro.org> > >> > --- > >> > drivers/gpu/drm/nouveau/nvkm/core/firmware.c | 1 + > >> > 1 file changed, 1 insertion(+) > >> > > >> > diff --git a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c > >> > b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c > >> > index 34ecd4a..058ff46 100644 > >> > --- a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c > >> > +++ b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c > >> > @@ -20,6 +20,7 @@ > >> > * DEALINGS IN THE SOFTWARE. > >> > */ > >> > #include <core/device.h> > >> > +#include <core/firmware.h> > >> > > >> > /** > >> > * nvkm_firmware_get - load firmware from the official nvidia/chip/ > >> > directory > >> > -- > >> > 2.7.4 > >> > > >> > _______________________________________________ > >> > Nouveau mailing list > >> > Nouveau at lists.freedesktop.org > >> > https://lists.freedesktop.org/mailman/listinfo/nouveau > > > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20161025/505381b3/attachment.html>
