On Sat, Oct 22, 2016 at 4:48 AM, Baoyou Xie <baoyou.xie at linaro.org> wrote: > We get 1 warning when building kernel with W=1: > drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c:37:6: warning: no previous prototype > for 'amdgpu_pm_acpi_event_handler' [-Wmissing-prototypes] > > In fact, this function is defined in > drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c, but should be declared > in a header file. So this patch moves the function declaration > to drivers/gpu/drm/amd/amdgpu/amdgpu.h.
I want to try and avoid making amdgpu.h a random dumping ground for function defs. Let's put it in amdgpu_pm.h instead. How about the attached patch? Alex > > Signed-off-by: Baoyou Xie <baoyou.xie at linaro.org> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 ++ > drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 1 - > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h > b/drivers/gpu/drm/amd/amdgpu/amdgpu.h > index 039b57e..c0bc42b 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h > @@ -2145,6 +2145,8 @@ void amdgpu_io_wreg(struct amdgpu_device *adev, u32 > reg, u32 v); > u32 amdgpu_mm_rdoorbell(struct amdgpu_device *adev, u32 index); > void amdgpu_mm_wdoorbell(struct amdgpu_device *adev, u32 index, u32 v); > > +void amdgpu_pm_acpi_event_handler(struct amdgpu_device *adev); > + > /* > * Registers read & write functions. > */ > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c > index 5796539..d77d630 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c > @@ -33,7 +33,6 @@ > #include "amd_acpi.h" > #include "atom.h" > > -extern void amdgpu_pm_acpi_event_handler(struct amdgpu_device *adev); > /* Call the ATIF method > */ > /** > -- > 2.7.4 > > _______________________________________________ > dri-devel mailing list > dri-devel at lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-drm-amdgpu-amdgpu_pm_acpi_event_handler-definition-t.patch Type: text/x-patch Size: 1925 bytes Desc: not available URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20161024/6a116239/attachment.bin>
