Please Review. Best Regards Rex
-----Original Message----- From: Dan Carpenter [mailto:dan.carpen...@oracle.com] Sent: Wednesday, October 12, 2016 2:12 PM To: Zhu, Rex Cc: dri-devel at lists.freedesktop.org Subject: [bug report] drm/amd/powerplay: implement smu7 hwmgr to manager asics with smu ip version 7. Hello Rex Zhu, This is a semi-automatic email about new static checker warnings. The patch 599a7e9fe1b6: "drm/amd/powerplay: implement smu7 hwmgr to manager asics with smu ip version 7." from Sep 9, 2016, leads to the following Smatch complaint: drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/smu7_hwmgr.c:1463 smu7_get_evv_voltages() error: we previously assumed 'table_info' could be null (see line 1455) drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/smu7_hwmgr.c 1454 1455 if (table_info != NULL) ^^^^^^^^^^^^^^^^^ Check for non-NULL. 1456 sclk_table = table_info->vdd_dep_on_sclk; 1457 1458 for (i = 0; i < SMU7_MAX_LEAKAGE_COUNT; i++) { 1459 vv_id = ATOM_VIRTUAL_VOLTAGE_ID0 + i; 1460 1461 if (data->vdd_gfx_control == SMU7_VOLTAGE_CONTROL_BY_SVID2) { 1462 if (0 == phm_get_sclk_for_voltage_evv(hwmgr, 1463 table_info->vddgfx_lookup_table, vv_id, &sclk)) { ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Unchecked dereference. 1464 if (phm_cap_enabled(hwmgr->platform_descriptor.platformCaps, 1465 PHM_PlatformCaps_ClockStretcher)) { regards, dan carpenter -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-drm-amd-powerplay-fix-static-checker-warnings-in-smu.patch Type: application/octet-stream Size: 1105 bytes Desc: 0001-drm-amd-powerplay-fix-static-checker-warnings-in-smu.patch URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20161013/7bf264a5/attachment-0001.obj>
