On Fri, Nov 18, 2016 at 09:52:56PM +0200, ville.syrjala at linux.intel.com wrote: > From: Ville Syrjälä <ville.syrjala at linux.intel.com> > > Populate the fb->format to point at the correct format information > structure. > > Cc: linux-graphics-maintainer at vmware.com > Cc: Sinclair Yeh <syeh at vmware.com> > Cc: Thomas Hellstrom <thellstrom at vmware.com> > Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com> > --- > drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c > b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c > index 5788913ca8f9..77f936e3056e 100644 > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c > @@ -589,6 +589,7 @@ static int vmw_kms_new_framebuffer_surface(struct > vmw_private *dev_priv, > > vfbs->base.base.dev = dev; > /* XXX get the first 4 from the surface info */ > + vfbs->base.base.format = drm_format_info(pixel_format); > vfbs->base.base.pixel_format = pixel_format; > vfbs->base.base.bits_per_pixel = mode_cmd->bpp; > vfbs->base.base.pitches[0] = mode_cmd->pitch;
If you change the earlier patch to just use fill_fb_struct this one here isn't needed. -Daniel > @@ -897,6 +898,7 @@ static int vmw_kms_new_framebuffer_dmabuf(struct > vmw_private *dev_priv, > } > > vfbd->base.base.dev = dev; > + vfbd->base.base.format = drm_format_info(pixel_format); > vfbd->base.base.pixel_format = pixel_format; > vfbd->base.base.bits_per_pixel = mode_cmd->bpp; > vfbd->base.base.pitches[0] = mode_cmd->pitch; > -- > 2.7.4 > > _______________________________________________ > dri-devel mailing list > dri-devel at lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
