On 23/11/16 12:13, Sekhar Nori wrote: > On Wednesday 23 November 2016 05:37 PM, Sudeep Holla wrote: >>> So, the if(!of_node_get()) is just an expensive NULL pointer check. I >>> think >>> it is better to be explicit about it by not using of_node_get/put() at >>> all. >>> How about: >>> >> >> Are we planning to use this in any time sensitive paths? Anyways I am >> fine removing them. > > Not worried about the time taken as much as it serving as a bad example > and getting carried over to other places where the impact might actually > be real. >
Ah OK, sure. -- Regards, Sudeep