Hi Ville,
Thank you for the patch.
On Thursday 17 Nov 2016 18:14:21 ville.syrjala at linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
>
> Avoid the format info lookup and just use the pointer stored under
> drm_framebuffer.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> ---
> drivers/gpu/drm/drm_atomic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c
> index 85466cc67819..cb6ab0106b0b 100644
> --- a/drivers/gpu/drm/drm_atomic.c
> +++ b/drivers/gpu/drm/drm_atomic.c
> @@ -960,7 +960,7 @@ static void drm_atomic_plane_print_state(struct
> drm_printer *p, drm_printf(p, "\tfb=%u\n", state->fb ? state->fb->base.id :
> 0);
> if (state->fb) {
> struct drm_framebuffer *fb = state->fb;
> - int i, n = drm_format_num_planes(fb->pixel_format);
> + int i, n = fb->format->num_planes;
Assuming you adress my concerns in patch 19/32,
Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> struct drm_format_name_buf format_name;
>
> drm_printf(p, "\t\tformat=%s\n",
--
Regards,
Laurent Pinchart
