Op 30-05-16 om 11:18 schreef Laurent Pinchart: > Hi Daniel, > > Thank you for the patch. > > This looks good to me as the resulting code is mostly similar. However, the > for_each_*_in_state macros end with an for_each_if() that tests if the > object's state is NULL, which isn't present in this code. I'm wondering > whether that was an oversight on my side possibly leading to a crash when > dereferencing a NULL state, or an unneeded check in the macros. Can > atomic_state->*_states[i] be NULL if atomic_state->*[i] is not NULL ? Not in any normal case.
- [PATCH 00/26] RFC: generic nonblocking support in the at... Daniel Vetter
- [PATCH 01/26] drm/atomic-helper: use for_each_*_in_... Daniel Vetter
- [Intel-gfx] [PATCH 01/26] drm/atomic-helper: us... Maarten Lankhorst
- [Intel-gfx] [PATCH 01/26] drm/atomic-helper... Daniel Vetter
- [PATCH 02/26] drm/i915: Use drm_atomic_get_existing... Daniel Vetter
- [Intel-gfx] [PATCH 02/26] drm/i915: Use drm_ato... Maarten Lankhorst
- [PATCH 03/26] drm/msm: Use for_each_*_in_state Daniel Vetter
- [PATCH 04/26] drm/rcar-du: Use for_each_*_in_state Daniel Vetter
- [PATCH 04/26] drm/rcar-du: Use for_each_*_in_st... Laurent Pinchart
- [Intel-gfx] [PATCH 04/26] drm/rcar-du: Use ... Maarten Lankhorst
- [Intel-gfx] [PATCH 04/26] drm/rcar-du: ... Daniel Vetter
- [Intel-gfx] [PATCH 04/26] drm/rcar... Laurent Pinchart
- [Intel-gfx] [PATCH 04/26] drm/... Daniel Vetter
- [Intel-gfx] [PATCH 04/26] ... Laurent Pinchart
- [Intel-gfx] [PATCH 04/26] ... Daniel Vetter
- [Intel-gfx] [PATCH 04/26] ... Laurent Pinchart
- [PATCH 05/26] drm/vc4: Use for_each_plane_in_state Daniel Vetter
- [PATCH 06/26] drm/atomic: Add __drm_atomic_get_curr... Daniel Vetter
- [Intel-gfx] [PATCH 06/26] drm/atomic: Add __drm... Maarten Lankhorst
- [Intel-gfx] [PATCH 06/26] drm/atomic: Add _... Daniel Vetter