On 26/04/16 23:35, Laurent Pinchart wrote: > The omapdrm DSS manager enable/disable operations check the DSS manager > state to avoid double enabling/disabling. Move that code to the DSS > manager to decrease the dependency of the DRM layer to the DSS layer.
Shouldn't omapdrm know if the CRTC is enabled or not, and avoid double-enable/disable by just looking at its internal state? If so, we could remove dispc_mgr_is_enabled() call as you do, and add a WARN_ON() to omapdss if the mgr is already enabled/disabled to catch bugs in omapdrm. Tomi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: OpenPGP digital signature URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20160510/f7ce23a5/attachment.sig>
