> -----Original Message----- > From: David Binderman [mailto:linuxdev.baldrick at gmail.com] > Sent: Monday, June 13, 2016 4:16 AM > To: Deucher, Alexander; Koenig, Christian; airlied at linux.ie; dri- > devel at lists.freedesktop.org; linux-kernel at vger.kernel.org; > dcb314 at hotmail.com > Subject: linux-4.7-rc3/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:4836: > wierd condition ? > > Hello there, > > linux-4.7-rc3/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:4836]: (style) > Boolean result is used in bitwise operation. Clarify expression with > parentheses. > > Source code is > > if ((ring->me == me_id) & (ring->pipe == pipe_id)) > > Maybe better code > > if ((ring->me == me_id) && (ring->pipe == pipe_id)) >
Good catch. Fixed in the attached patch. > Also in the same file: > > [drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:3866]: (style) Variable 'data' > is assigned a value that is never used. The readback of the register here is needed to wake up the block after disabling powergating. > [drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:4321]: (style) Variable > 'mc_shared_chmap' is assigned a value that is never used. I think this one can be dropped. > [drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:4657]: (style) Variable 'tmp' > is assigned a value that is never used. > This operation requires a posted write (i.e., a read back of the register to make sure the write has completed). Thanks! Alex > Regards > > David Binderman -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-drm-amdgpu-gfx7-fix-broken-condition-check.patch Type: application/octet-stream Size: 1036 bytes Desc: 0001-drm-amdgpu-gfx7-fix-broken-condition-check.patch URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20160613/d6888944/attachment.obj>
