[PATCH] drm/rockchip: Delete an unnecessary check before drm_gem_object_unreference_unlocked()

[SF Markus Elfring]

From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Fri, 15 Jul 2016 15:23:22 +0200

The drm_gem_object_unreference_unlocked() function tests whether
its argument is NULL and then returns immediately.
Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring at users.sourceforge.net>
---
 drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_fb.c 
b/drivers/gpu/drm/rockchip/rockchip_drm_fb.c
index 20f12bc..6f64e79 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_fb.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_fb.c
@@ -43,14 +43,10 @@ struct drm_gem_object *rockchip_fb_get_gem_obj(struct 
drm_framebuffer *fb,
 static void rockchip_drm_fb_destroy(struct drm_framebuffer *fb)
 {
        struct rockchip_drm_fb *rockchip_fb = to_rockchip_fb(fb);
-       struct drm_gem_object *obj;
        int i;

-       for (i = 0; i < ROCKCHIP_MAX_FB_BUFFER; i++) {
-               obj = rockchip_fb->obj[i];
-               if (obj)
-                       drm_gem_object_unreference_unlocked(obj);
-       }
+       for (i = 0; i < ROCKCHIP_MAX_FB_BUFFER; i++)
+               drm_gem_object_unreference_unlocked(rockchip_fb->obj[i]);

        drm_framebuffer_cleanup(fb);
        kfree(rockchip_fb);
-- 
2.9.1