Hi Archit, Am Mittwoch, den 13.07.2016, 11:25 +0530 schrieb Archit Taneja: [...] > > diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig > > index a1419214..ebcad29 100644 > > --- a/drivers/gpu/drm/bridge/Kconfig > > +++ b/drivers/gpu/drm/bridge/Kconfig > > @@ -58,6 +58,14 @@ config DRM_SII902X > > ---help--- > > Silicon Image sii902x bridge chip driver. > > > > +config DRM_TOSHIBA_TC358767 > > + tristate "Toshiba TC358767 eDP bridge" > > Can we add a 'depends on OF ' here, or wrap around the > 'tc->bridge.of_node' access with a CONFIG_OF check? It currently > breaks build for non-OF platforms.
Done. [...] > > + int test_pattern; > > This still doesn't seem to be initialized. Didn't we want this > to be a module param? If we're not sure yet, it would be fine > just to set tc->test_pattern explicitly to 0 and add a comment. And done, sorry I forgot this. Now that I have added the module parameter, I have and actually tested the test pattern code and noticed that I also have to set the pixel clock rate. I'll send a new version shortly. regards Philipp
