"brick" is allocated with devm_kzalloc() so freeing it with kfree()
leads to a double free.  We can just delete it.

Fixes: a7ba8310c7f5 ('drm/tegra: sor: Implement sor1_brick clock')
Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>

diff --git a/drivers/gpu/drm/tegra/sor.c b/drivers/gpu/drm/tegra/sor.c
index 8425eda..e750ced 100644
--- a/drivers/gpu/drm/tegra/sor.c
+++ b/drivers/gpu/drm/tegra/sor.c
@@ -345,7 +345,6 @@ static struct clk *tegra_clk_sor_brick_register(struct 
tegra_sor *sor,
 {
        struct tegra_clk_sor_brick *brick;
        struct clk_init_data init;
-       struct clk *clk;

        brick = devm_kzalloc(sor->dev, sizeof(*brick), GFP_KERNEL);
        if (!brick)
@@ -361,11 +360,7 @@ static struct clk *tegra_clk_sor_brick_register(struct 
tegra_sor *sor,

        brick->hw.init = &init;

-       clk = devm_clk_register(sor->dev, &brick->hw);
-       if (IS_ERR(clk))
-               kfree(brick);
-
-       return clk;
+       return devm_clk_register(sor->dev, &brick->hw);
 }

 static int tegra_sor_dp_train_fast(struct tegra_sor *sor,

Reply via email to