On 07/01/2016 03:59 PM, Dan Carpenter wrote: > We should be checking "phy_provider" here not "phy". > > Fixes: 2e54c14e310f ('drm/mediatek: Add DSI sub driver') > Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> >
Reviewed-by: Matthias Brugger <matthias.bgg at gmail.com> > diff --git a/drivers/gpu/drm/mediatek/mtk_mipi_tx.c > b/drivers/gpu/drm/mediatek/mtk_mipi_tx.c > index cf8f38d..1c366f8 100644 > --- a/drivers/gpu/drm/mediatek/mtk_mipi_tx.c > +++ b/drivers/gpu/drm/mediatek/mtk_mipi_tx.c > @@ -431,7 +431,7 @@ static int mtk_mipi_tx_probe(struct platform_device *pdev) > phy_set_drvdata(phy, mipi_tx); > > phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate); > - if (IS_ERR(phy)) { > + if (IS_ERR(phy_provider)) { > ret = PTR_ERR(phy_provider); > return ret; > } >