[linux-sunxi] [PATCH v2 00/26] drm: Add Allwinner A10 display engine support

Priit Laes Sat, 20 Feb 2016 15:45:41 +0200

On Thu, 2016-01-14 at 16:24 +0100, Maxime Ripard wrote:
> Hi everyone,
> 
> The Allwinner SoCs (except for the very latest ones) all share the
> same set of controllers, loosely coupled together to form the display
> pipeline.
> 
> Depending on the SoC, the number of instances of the controller will
> change (2 instances of each in the A10, only one in the A13, for
> example), and the output availables will change too (HDMI, composite,
> VGA on the A20, none of them on the A13).
> 
> On most featured SoCs, it looks like that:
> 
> Â +--------------------------------------------+
> Â |Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â RAMÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â 
> Â Â Â Â Â |
> Â +--------------------------------------------+
> Â Â Â Â Â Â Â |Â Â Â Â Â Â Â Â Â Â Â Â |Â Â Â Â Â Â |Â Â Â Â Â Â Â Â Â Â Â Â |
> Â Â Â Â Â Â Â vÂ Â Â Â Â Â Â Â Â Â Â Â |Â Â Â Â Â Â |Â Â Â Â Â Â Â Â Â Â Â Â v
> Â +----------------+ |Â Â Â Â Â Â | +----------------+
> Â |Â Â Â Â FrontendÂ Â Â Â | |Â Â Â Â Â Â | |Â Â Â Â FrontendÂ Â Â Â |
> Â +----------------+ |Â Â Â Â Â Â | +----------------+
> Â Â Â Â Â Â Â Â Â |Â Â Â Â Â Â Â Â Â Â |Â Â Â Â Â Â |Â Â Â Â Â Â Â Â Â |
> Â Â Â Â Â Â Â Â Â vÂ Â Â Â Â Â Â Â Â Â |Â Â Â Â Â Â |Â Â Â Â Â Â Â Â Â v
> Â +----------------+ |Â Â Â Â Â Â | +----------------+
> Â |Â Â Â Â BackendÂ Â Â Â Â |<+Â Â Â Â Â Â +>|Â Â Â Â BackendÂ Â Â Â Â |
> Â +----------------+Â Â Â Â Â Â Â Â Â Â +----------------+
> Â Â Â Â Â Â Â Â Â |Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â |
> Â Â Â Â Â Â Â Â Â vÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â v
> Â +----------------+Â Â Â Â Â Â Â Â Â Â +----------------+---> LVDS
> Â |Â Â Â Â Â Â TCONÂ Â Â Â Â Â |Â Â Â Â Â Â Â Â Â Â |Â Â Â Â Â Â TCONÂ Â Â Â 
> Â Â |---> RGB
> Â +----------------+Â Â Â Â Â Â Â Â Â Â +----------------+
> Â Â Â Â Â Â Â |Â Â Â Â Â Â Â +---+Â Â Â Â Â Â Â +---+Â Â Â Â Â Â Â Â Â Â |
> Â Â Â Â Â Â Â |Â Â Â Â Â Â Â Â Â Â Â |Â Â Â Â Â Â Â |Â Â Â Â Â Â Â Â Â Â Â Â 
> Â Â |
> Â Â Â Â Â Â Â vÂ Â Â Â Â Â Â Â Â Â Â vÂ Â Â Â Â Â Â vÂ Â Â Â Â Â Â Â Â Â Â Â 
> Â Â v
> Â +------------+Â Â +------------+Â Â +------------+---> VGA
> Â | TV Encoder |Â Â |Â Â Â Â HDMIÂ Â Â Â |Â Â | TV Encoder |---> Composite
> Â +------------+Â Â +------------+Â Â +------------+
> 
> The current code only assumes that there is a single instance of all
> the controllers. It also supports only the RGB and Composite
> interfaces.


I found some time to play with it (with intention to get it running
also on sun7i and sun4i) and ran into this when trying to build
sun4i_drm as module:

ERROR: "sun4i_tcon1_mode_set" [drivers/gpu/drm/sun4i/sun4i_tv.ko] undefined!
ERROR: "sun4i_backend_apply_color_correction" 
[drivers/gpu/drm/sun4i/sun4i_tv.ko] undefined!
ERROR: "sun4i_tcon_channel_disable" [drivers/gpu/drm/sun4i/sun4i_tv.ko] 
undefined!
ERROR: "sun4i_tcon_channel_enable" [drivers/gpu/drm/sun4i/sun4i_tv.ko] 
undefined!
ERROR: "clk_unregister_composite" [drivers/gpu/drm/sun4i/sun4i_tcon.ko] 
undefined!
ERROR: "sun4i_rgb_init" [drivers/gpu/drm/sun4i/sun4i_tcon.ko] undefined!
ERROR: "clk_register_composite" [drivers/gpu/drm/sun4i/sun4i_tcon.ko] undefined!
ERROR: "sun4i_backend_update_layer_coord" [drivers/gpu/drm/sun4i/sun4i-drm.ko] 
undefined!
ERROR: "sun4i_backend_update_layer_formats" 
[drivers/gpu/drm/sun4i/sun4i-drm.ko] undefined!
ERROR: "sun4i_tcon_channel_disable" [drivers/gpu/drm/sun4i/sun4i-drm.ko] 
undefined!
ERROR: "sun4i_tcon_enable_vblank" [drivers/gpu/drm/sun4i/sun4i-drm.ko] 
undefined!
ERROR: "sun4i_backend_update_layer_buffer" [drivers/gpu/drm/sun4i/sun4i-drm.ko] 
undefined!
ERROR: "sun4i_backend_layer_enable" [drivers/gpu/drm/sun4i/sun4i-drm.ko] 
undefined!
ERROR: "sun4i_tcon_channel_enable" [drivers/gpu/drm/sun4i/sun4i-drm.ko] 
undefined!
ERROR: "sun4i_tcon_enable" [drivers/gpu/drm/sun4i/sun4i-drm.ko] undefined!
ERROR: "sun4i_tcon_disable" [drivers/gpu/drm/sun4i/sun4i-drm.ko] undefined!
ERROR: "sun4i_tcon0_mode_set" [drivers/gpu/drm/sun4i/sun4i-drm.ko] undefined!
ERROR: "sun4i_backend_commit" [drivers/gpu/drm/sun4i/sun4i-drm.ko] undefined!
scripts/Makefile.modpost:91: recipe for target '__modpost' failed



> 
> Let me know what you think,
> Maxime
> 
> Changes from v1:
> Â  - Rebased on top of 4.4
> 
> Â  - Merged the clock drivers for the display and TCON channel 0
> clocks
> Â  - Replaced the container_of calls in the display reset clocks to an
> Â Â Â Â inline function
> Â  - Checked the return code of of_clk_parent_fill in the clocks
> Â Â Â Â drivers
> Â  - Checked the return code of of_clk_add_provider in the tcon-ch1
> and
> Â Â Â Â PLL3 clocks
> Â  - Added missing clocks headers
> Â  - Created a composite clock unregister function
> 
> Â  - Moved the binding documentation to
> Â Â Â Â Documentation/devicetree/bindings/display
> Â  - Added the clocks binding documentation
> Â  - Added the Olimex vendor to the list of DT vendors
> Â  - Moved to the OF graph representation and the component framework
> 
> Â  - Moved the reset cells count check into the reset framework to
> Â Â Â Â avoid duplicating the code in every xlate implementation.
> Â  - Made the reset_ops const
> 
> Â  - Reworked the DRM cmdline mode parsing code to allow named mode
> Â  - Fixed the TV mode lookup when the mode name is not present (for
> Â Â Â Â example because it was given by the userspace)
> 
> Â  - Made the driver outputs optional (to avoid crashing when a board
> Â Â Â Â doesn't have either a panel or a composite output enabled)
> Â  - Added multiple plane support with transparency
> Â  - Moved the backend registers writes commit in the CRTC
> atomic_flush
> Â Â Â Â callback
> Â  - Removed the load / unload functions
> Â  - Removed the enabled booleans in my private structure and removed
> Â Â Â Â the implicit call to disable_unused_functions in the DRM core to
> Â Â Â Â push it in the drivers.
> Â  - Fixed a few bitmasks on some bitfields definition
> Â  - Fixed the RGB connector mode validation that was not testing the
> Â Â Â Â right values
> 
> Matthias Brugger (1):
> Â  clk: Add regmap support
> 
> Maxime Ripard (25):
> Â  reset: Move DT cell size check to the core
> Â  reset: Make reset_control_ops const
> Â  clk: composite: Add unregister function
> Â  clk: sunxi: Add display and TCON0 clocks driver
> Â  clk: sunxi: Add PLL3 clock
> Â  clk: sunxi: Add TCON channel1 clock
> Â  clk: sun5i: add DRAM gates
> Â  ARM: sun5i: dt: Add pll3 and pll7 clocks
> Â  ARM: sun5i: a13: Add display and TCON clocks
> Â  ARM: sun5i: Add DRAM gates
> Â  ARM: sun5i: Add TV encoder gate to the DTSI
> Â  drm/fb_cma_helper: Remove implicit call to disable_unused_functions
> Â  drm/modes: Rewrite the command line parser
> Â  drm/modes: Support modes names on the command line
> Â  drm: Add Allwinner A10 Display Engine support
> Â  drm: sun4i: Add DT bindings documentation
> Â  drm: sun4i: Add RGB output
> Â  drm: sun4i: Add composite output
> Â  drm: sun4i: tv: Add PAL output standard
> Â  drm: sun4i: tv: Add NTSC output standard
> Â  ARM: sun5i: r8: Add display blocks to the DTSI
> Â  ARM: sun5i: chip: Enable the TV Encoder
> Â  devicetree: Add olimex vendor prefix
> Â  drm/panel: simple: Add timings for the Olimex LCD-OLinuXino-4.3TS
> Â  DO NOT MERGE: ARM: sun5i: chip: Enable the LCD panel
> 
> Â Documentation/devicetree/bindings/clock/sunxi.txtÂ Â |Â Â Â 5 +
> Â .../display/panel/olimex,lcd-olinuxino-43-ts.txtÂ Â Â |Â Â Â 7 +
> Â .../bindings/display/sunxi/sun4i-drm.txtÂ Â Â Â Â Â Â Â Â Â Â | 228 +++++++
> Â .../devicetree/bindings/vendor-prefixes.txtÂ Â Â Â Â Â Â Â |Â Â Â 1 +
> Â arch/arm/boot/dts/sun5i-a10s.dtsiÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â |Â Â Â 
> 7 +-
> Â arch/arm/boot/dts/sun5i-a13.dtsiÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â |Â Â 
> 46 +-
> Â arch/arm/boot/dts/sun5i-r8-chip.dtsÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â |Â Â 17 +
> Â arch/arm/boot/dts/sun5i-r8.dtsiÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â | 
> 139 ++++-
> Â arch/arm/boot/dts/sun5i.dtsiÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â 
> |Â Â 62 ++
> Â drivers/clk/MakefileÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â 
> Â Â Â |Â Â Â 1 +
> Â drivers/clk/clk-composite.cÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â 
> |Â Â 15 +
> Â drivers/clk/clk-divider.cÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â 
> Â |Â Â 68 ++-
> Â drivers/clk/clk-gate.cÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â 
> Â Â |Â Â 54 +-
> Â drivers/clk/clk-io.cÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â 
> Â Â Â |Â Â 48 ++
> Â drivers/clk/clk-io.hÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â 
> Â Â Â |Â Â 22 +
> Â drivers/clk/clk-mux.cÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â 
> Â Â Â |Â Â 94 ++-
> Â drivers/clk/sunxi/MakefileÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â 
> |Â Â Â 3 +
> Â drivers/clk/sunxi/clk-simple-gates.cÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â |Â Â Â 2 +
> Â drivers/clk/sunxi/clk-sun4i-display.cÂ Â Â Â Â Â Â Â Â Â Â Â Â Â | 241 
> ++++++++
> Â drivers/clk/sunxi/clk-sun4i-pll3.cÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â |Â Â 90 
> +++
> Â drivers/clk/sunxi/clk-sun4i-tcon-ch1.cÂ Â Â Â Â Â Â Â Â Â Â Â Â | 154 +++++
> Â drivers/gpu/drm/KconfigÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â 
> Â Â |Â Â Â 2 +
> Â drivers/gpu/drm/MakefileÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â 
> Â |Â Â Â 3 +-
> Â drivers/gpu/drm/drm_crtc.cÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â 
> |Â Â Â 3 +-
> Â drivers/gpu/drm/drm_fb_cma_helper.cÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â |Â Â Â 3 
> -
> Â drivers/gpu/drm/drm_fb_helper.cÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â |Â Â 
> Â 4 +
> Â drivers/gpu/drm/drm_modes.cÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â 
> | 327 ++++++----
> Â drivers/gpu/drm/imx/imx-drm-core.cÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â |Â Â Â 
> 1 +
> Â drivers/gpu/drm/panel/panel-simple.cÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â |Â Â 26 +
> Â drivers/gpu/drm/sti/sti_drv.cÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â |Â 
> Â Â 1 +
> Â drivers/gpu/drm/sun4i/KconfigÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â |Â 
> Â 14 +
> Â drivers/gpu/drm/sun4i/MakefileÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â |Â 
> Â 12 +
> Â drivers/gpu/drm/sun4i/sun4i_backend.cÂ Â Â Â Â Â Â Â Â Â Â Â Â Â | 321 
> ++++++++++
> Â drivers/gpu/drm/sun4i/sun4i_backend.hÂ Â Â Â Â Â Â Â Â Â Â Â Â Â | 160 +++++
> Â drivers/gpu/drm/sun4i/sun4i_crtc.cÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â | 120 
> ++++
> Â drivers/gpu/drm/sun4i/sun4i_crtc.hÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â |Â Â 30 
> +
> Â drivers/gpu/drm/sun4i/sun4i_drv.cÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â | 325 
> ++++++++++
> Â drivers/gpu/drm/sun4i/sun4i_drv.hÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â |Â Â 
> 30 +
> Â drivers/gpu/drm/sun4i/sun4i_framebuffer.cÂ Â Â Â Â Â Â Â Â Â |Â Â 54 ++
> Â drivers/gpu/drm/sun4i/sun4i_framebuffer.hÂ Â Â Â Â Â Â Â Â Â |Â Â 19 +
> Â drivers/gpu/drm/sun4i/sun4i_layer.cÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â | 160 
> +++++
> Â drivers/gpu/drm/sun4i/sun4i_layer.hÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â |Â Â 30 +
> Â drivers/gpu/drm/sun4i/sun4i_rgb.cÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â | 229 
> +++++++
> Â drivers/gpu/drm/sun4i/sun4i_rgb.hÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â |Â Â 
> 18 +
> Â drivers/gpu/drm/sun4i/sun4i_tcon.cÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â | 521
> ++++++++++++++++
> Â drivers/gpu/drm/sun4i/sun4i_tcon.hÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â | 177 
> ++++++
> Â drivers/gpu/drm/sun4i/sun4i_tv.cÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â | 675
> +++++++++++++++++++++
> Â drivers/gpu/drm/tilcdc/tilcdc_drv.cÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â |Â Â Â 1 
> +
> Â drivers/reset/core.cÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â 
> Â Â Â |Â Â Â 6 +-
> Â include/drm/drm_modes.hÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â 
> Â Â |Â Â Â 1 +
> Â include/linux/clk-provider.hÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â 
> |Â Â 55 +-
> Â include/linux/reset-controller.hÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â |Â Â 
> Â 2 +-
> Â 52 files changed, 4455 insertions(+), 179 deletions(-)
> Â create mode 100644
> Documentation/devicetree/bindings/display/panel/olimex,lcd-olinuxino-
> 43-ts.txt
> Â create mode 100644
> Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt
> Â create mode 100644 drivers/clk/clk-io.c
> Â create mode 100644 drivers/clk/clk-io.h
> Â create mode 100644 drivers/clk/sunxi/clk-sun4i-display.c
> Â create mode 100644 drivers/clk/sunxi/clk-sun4i-pll3.c
> Â create mode 100644 drivers/clk/sunxi/clk-sun4i-tcon-ch1.c
> Â create mode 100644 drivers/gpu/drm/sun4i/Kconfig
> Â create mode 100644 drivers/gpu/drm/sun4i/Makefile
> Â create mode 100644 drivers/gpu/drm/sun4i/sun4i_backend.c
> Â create mode 100644 drivers/gpu/drm/sun4i/sun4i_backend.h
> Â create mode 100644 drivers/gpu/drm/sun4i/sun4i_crtc.c
> Â create mode 100644 drivers/gpu/drm/sun4i/sun4i_crtc.h
> Â create mode 100644 drivers/gpu/drm/sun4i/sun4i_drv.c
> Â create mode 100644 drivers/gpu/drm/sun4i/sun4i_drv.h
> Â create mode 100644 drivers/gpu/drm/sun4i/sun4i_framebuffer.c
> Â create mode 100644 drivers/gpu/drm/sun4i/sun4i_framebuffer.h
> Â create mode 100644 drivers/gpu/drm/sun4i/sun4i_layer.c
> Â create mode 100644 drivers/gpu/drm/sun4i/sun4i_layer.h
> Â create mode 100644 drivers/gpu/drm/sun4i/sun4i_rgb.c
> Â create mode 100644 drivers/gpu/drm/sun4i/sun4i_rgb.h
> Â create mode 100644 drivers/gpu/drm/sun4i/sun4i_tcon.c
> Â create mode 100644 drivers/gpu/drm/sun4i/sun4i_tcon.h
> Â create mode 100644 drivers/gpu/drm/sun4i/sun4i_tv.c
> 
> --Â 
> 2.6.4
>

[linux-sunxi] [PATCH v2 00/26] drm: Add Allwinner A10 display engine support

Reply via email to