[PATCH v4 01/11] drm/hisilicon: Add device tree binding for hi6220 display subsystem

[Xinliang Liu]

On 9 February 2016 at 04:12, Rob Herring <robh at kernel.org> wrote:
> On Sat, Feb 06, 2016 at 11:24:48AM +0800, Xinliang Liu wrote:
>> Add ADE display controller binding doc.
>> Add DesignWare DSI Host Controller v1.20a binding doc.
>
> One comment, otherwise:
>
> Acked-by: Rob Herring <robh at kernel.org>
>
>> +Board specific:
>> +     &dsi {
>> +             status = "ok";
>> +
>> +             ports {
>> +                     /* 1 for output port */
>> +                     port at 1 {
>> +                             #address-cells = <1>;
>> +                             #size-cells = <0>;
>> +                             reg = <1>;
>> +
>> +                             /* 0 for bridge, other value for panel */
>
> The endpoint address would not change based on bridge or panel. So you
> can drop the unit address here.

yes, I can drop the unit address, since it only support bridge in the
DSI code currently, right?

One question: How to distinguish panel and bridge endpoint?  I am
thinking to support panel now.

Thanks,
-xinliang

>
>> +                             dsi_out0: endpoint at 0 {
>> +                                     reg = <0>;
>> +                                     remote-endpoint = <&adv7533_in>;
>> +                             };
>> +                     };
>> +             };
>> +     };