On 14/12/16 02:27, Laurent Pinchart wrote: > Instead of conditioning planes update based on the DSS manager hardware > state, use the enabled field newly added to the omap_crtc structure. > This reduces the dependency from the DRM layer to the DSS layer. > > The enabled field is a transitory measure, the implementation should use > the CRTC atomic state instead. However, given that CRTCs are currently > not enabled/disabled through their .enable() and .disable() operations > but through a convoluted code paths starting at the associated encoder > operations, there is not clear guarantee that the atomic state always > matches the hardware state. This will be refactored later, at which > point the enabled field will be removed. > > Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com> > --- > Changes since v3: > > - Clarify commit message > > Changes since v2: > > - Use enabled field in struct omap_crtc instead of CRTC atomic state > --- > drivers/gpu/drm/omapdrm/omap_crtc.c | 22 +++++++++++++--------- > 1 file changed, 13 insertions(+), 9 deletions(-)
Reviewed-by: Tomi Valkeinen <tomi.valkeinen at ti.com> Tomi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: OpenPGP digital signature URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20161214/4d3b0515/attachment.sig>