On 08/26/2016 05:58 PM, Philipp Zabel wrote:
> Hi Marek,
>
> Am Freitag, den 26.08.2016, 16:24 +0200 schrieb Marek Vasut:
>> This display expects DE pin to be active high, add the necessary flag.
>>
>> Signed-off-by: Marek Vasut <marex at denx.de>
>> Cc: Philipp Zabel <p.zabel at pengutronix.de>
>> Cc: Thierry Reding <treding at nvidia.com>
>> ---
>> drivers/gpu/drm/panel/panel-simple.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/panel/panel-simple.c
>> b/drivers/gpu/drm/panel/panel-simple.c
>> index 3a7bdf1..f4c546d 100644
>> --- a/drivers/gpu/drm/panel/panel-simple.c
>> +++ b/drivers/gpu/drm/panel/panel-simple.c
>> @@ -1198,6 +1198,7 @@ static const struct panel_desc ortustech_com43h4m85ulc
>> = {
>> .height = 93,
>> },
>> .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
>> + .bus_flags = DRM_BUS_FLAG_DE_HIGH,
>
> Reviewed-by: Philipp Zabel <p.zabel at pengutronix.de>
>
> While at it, you could also add DRM_BUS_FLAG_PIXDATA_POSEDGE. The panel
> expects pixel data to be driven with the rising edge of the pixel clock,
> it samples on the falling edge.
Ah, let me add the flag and repost then.
--
Best regards,
Marek Vasut
