Hi John, On 23/08/16 06:50, John Stultz wrote: > This is an initial swing at getting the adv7511 hdmi bridge > audio support reviewed. > > I've taken the core audio work done by Lars-Peter Clausen, and > adapted by Srinivas Kandagatla and Archit Taneja, and tried to > rework it to use the hdmi-codec sound driver. > > This patchset, along with the i2s driver and dts changes allows > HDMI audio to work on the HiKey board. > > I'd really appreciate any thoughts or feedback.
Thanks for putting up these patches together, I tested them on DB410c on top of v4.8-rc3 with a dt patch(https://git.linaro.org/people/srinivas.kandagatla/linux.git/commit/ac06c0e91b1a0ac83a0d2946e593fcdd73836896) and it works great. Tested-by: Srinivas Kandagatla <srinivas.kandagatla at linaro.org> thanks, srini > > thanks > -john > > Cc: David Airlie <airlied at linux.ie> > Cc: Archit Taneja <architt at codeaurora.org> > Cc: Laurent Pinchart <laurent.pinchart at ideasonboard.com> > Cc: Wolfram Sang <wsa+renesas at sang-engineering.com> > Cc: Srinivas Kandagatla <srinivas.kandagatla at linaro.org> > Cc: "Ville Syrjälä" <ville.syrjala at linux.intel.com> > Cc: Boris Brezillon <boris.brezillon at free-electrons.com> > Cc: Andy Green <andy at warmcat.com> > Cc: Dave Long <dave.long at linaro.org> > Cc: Guodong Xu <guodong.xu at linaro.org> > Cc: Zhangfei Gao <zhangfei.gao at linaro.org> > Cc: Mark Brown <broonie at kernel.org> > Cc: Lars-Peter Clausen <lars at metafoo.de> > Cc: Jose Abreu <joabreu at synopsys.com> > Cc: dri-devel at lists.freedesktop.org > Andy Green (1): > drm/bridge: adv7511: Initialize audio packet on adv7533 > > Archit Taneja (1): > drm/bridge: adv7511: Move the common data structures to header file > > John Stultz (1): > drm/bridge: adv7511: Add Audio support. > > Srinivas Kandagatla (1): > drm/bridge: adv7511: Enable the audio data and clock pads on adv7533 > > drivers/gpu/drm/bridge/adv7511/Kconfig | 1 + > drivers/gpu/drm/bridge/adv7511/Makefile | 2 +- > drivers/gpu/drm/bridge/adv7511/adv7511.h | 12 ++ > drivers/gpu/drm/bridge/adv7511/adv7511_audio.c | 208 > +++++++++++++++++++++++++ > drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 9 +- > drivers/gpu/drm/bridge/adv7511/adv7533.c | 23 +++ > 6 files changed, 252 insertions(+), 3 deletions(-) > create mode 100644 drivers/gpu/drm/bridge/adv7511/adv7511_audio.c >