On Tue, Aug 23, 2016 at 5:54 PM, Daniel Vetter <daniel at ffwll.ch> wrote:
> On Tue, Aug 23, 2016 at 05:39:36PM +0200, Andrea Merello wrote: > > On Tue, Aug 23, 2016 at 5:20 PM, Daniel Vetter <daniel at ffwll.ch> wrote: > > > > > On Tue, Aug 23, 2016 at 04:08:04PM +0200, Andrea Merello wrote: > > > > Introduce drm_simple_display_pipe_attach_bridge() in order > > > > to make it possible to use drm encoders with the simple display > > > > pipes managed by simple_kms_helpers > > > > > > > > Suggested-by: Daniel Vetter <daniel at ffwll.ch> > > > > Signed-off-by: Andrea Merello <andrea.merello at gmail.com> > > > > Cc: Noralf Trønnes <noralf at tronnes.org> > > > > Cc: Daniel Vetter <daniel at ffwll.ch> > > > > Cc: David Airlie <airlied at linux.ie> > > > > > > Threading of your patch series is somehow broken, usually that should > all > > > work nicely if you've set up git send-email. > > > > > > One question: Should we ahve a drm_simple_display_pipe_detach_bridge > (for > > > cleanup) too? > > > > > > > Unsure if it worths. May be nice to have a balanced pair, but it would > > probably end up in > > a quite redundant one-line func, that only calls drm_bridge_detach with > the > > very same argument. > > > > ..But of course if you want I can add it in v2 series. > > Yes it's just going to be a one-line, but it'll do a typecast and so > better encapsulate the internals of the simple pipe helper. I'm unsure about what do you mean here. Why a typecast? Wouldn't it be simply drm_simple_display_pipe_detach_bridge(struct drm_bridge *bridge) calling in turn drm_detach_bridge(struct drm_bridge *bridge) with the very same argument? Or if you want to stay behind the pipe, then it could be drm_simple_display_pipe_detach_bridge(struct drm_simple_display_pipe *pipe), but I would say it just does something like drm_bridge_detach(pipe->encoder.bridge), so I don't really get your point about the cast, sorry.. > I think that's > worth it - we have piles&piles of functions and #defines just to make > little one-line bits of code a notch more readable. > > And yes the symmetry is nice too ;-) > OK, then I'll add it :) Andrea > -Daniel > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch > -------------- next part -------------- An HTML attachment was scrubbed... URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20160823/4b952b0d/attachment.html>
