Hi, On 26 April 2016 at 00:33, Gustavo Padovan <gustavo at padovan.org> wrote: > +static inline struct drm_crtc *fence_to_crtc(struct fence *fence) > +{ > + if (fence->ops != &drm_crtc_fence_ops) > + return NULL;
Since this is (currently) only used before unconditional dereferences, maybe turn this into a BUG_ON instead of return NULL? Cheers, Daniel