On 04/22/2016 04:03 AM, Laurent Pinchart wrote: > Hi Archit, > > On Thursday 14 Apr 2016 20:26:11 Archit Taneja wrote: >> On 3/9/2016 4:27 PM, Archit Taneja wrote: >>> ADV7533 is a DSI to HDMI encoder chip. It's like ADV7511, but with an >>> additional DSI RX block that takes in DSI video mode output. >>> >>> Trying to get this driver merged has had some challenges: >>> >>> - ADV7533 has an I2C control bus, but acts as a DSI peripheral too. >>> >>> After discussions, it was concluded that we'd want to provide an >>> API to create MIPI DSI devices, rather than expose two different >>> interfaces on DT. The first version [1] tried the former approach >>> the second version [2] showed how the driver would look like if >>> exposed 2 DT nodes. This lateset patchset relies on the MIPI DSI >>> device creation API provided by [3], this has been accepted and >>> should be merged for 4.6. >>> >>> - The driver was designed as an I2C slave encoder. When ADV7533 >>> >>> patches were posted [1], it was modelled as a bridge, but ADV7511 >>> and others were still left as I2C slave encoders. This wasn't >>> accepted. After discussions, it was decided that ADV7511 too would >>> be converted into a bridge driver, and all the users of ADV7511 >>> should assume it is a bridge. This bridge conversion was done in >>> [4]. There is still some debate over whether the bridge driver be >>> involved in the connector creation, or the KMS driver that has >>> the whole view of the display pipeline. This discussion shouldn't >>> affect this patch set, though. >>> >>> This patch set enables ADV7533 support with the above two issues >>> now resolved. It also incorporates ADV7533 specific features and fixes >>> that we've discovered since the first version of this patch was posted. >>> >>> Tested on ADV7533 chips on DB410c. It should work on the Hikey board too. >>> I'd appreaciate if someone could test it on a ADV7511 platform since I >>> don't have one. >> >> Could you try this patch set on the rcar-du platform? It would help to >> verify if this doesn't break ADV7511. > > Basic testing didn't show any regression. For the whole series, > > Tested-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
Thanks! Archit -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
