On Wed, Apr 20, 2016 at 07:42:13PM +0100, Chris Wilson wrote: > The ioremap() hidden behind the io_mapping_map_wc() convenience helper > can be used for remapping multiple pages. Extend the helper so that > future callers can use it for larger ranges. > > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk> > Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com> > Cc: Daniel Vetter <daniel.vetter at intel.com> > Cc: Jani Nikula <jani.nikula at linux.intel.com> > Cc: David Airlie <airlied at linux.ie> > Cc: Yishai Hadas <yishaih at mellanox.com> > Cc: Dan Williams <dan.j.williams at intel.com> > Cc: Ingo Molnar <mingo at kernel.org> > Cc: "Peter Zijlstra (Intel)" <peterz at infradead.org> > Cc: David Hildenbrand <dahi at linux.vnet.ibm.com> > Cc: Luis R. Rodriguez <mcgrof at kernel.org> > Cc: intel-gfx at lists.freedesktop.org > Cc: dri-devel at lists.freedesktop.org > Cc: netdev at vger.kernel.org > Cc: linux-rdma at vger.kernel.org > Cc: linux-kernel at vger.kernel.org
We have 2 callers today, in the future, can you envision this API getting more options? If so, in order to avoid the pain of collateral evolutions I can suggest a descriptor being passed with the required settings / options. This lets you evolve the API without needing to go in and modify old users. If you choose not to that's fine too, just figured I'd chime in with that as I've seen the pain with other APIs, and I'm putting an end to the needless set of collateral evolutions this way. Other than that possible API optimization: Reviewed-by: Luis R. Rodriguez <mcgrof at kernel.org> Luis