This adds proper use of the variable ret by returning it
at the end of the function, psb_mmu_inset_pfn_sequence for
indicating to callers when an error has occurred. Further
more remove the unneeded double setting of ret to the error
code, -ENOMEM after checking if a call to the function,

Signed-off-by: Bastien Philbert <bastienphilbert at gmail.com>
---
 drivers/gpu/drm/gma500/mmu.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/gma500/mmu.c b/drivers/gpu/drm/gma500/mmu.c
index 0eaf11c..b832397 100644
--- a/drivers/gpu/drm/gma500/mmu.c
+++ b/drivers/gpu/drm/gma500/mmu.c
@@ -677,10 +677,9 @@ int psb_mmu_insert_pfn_sequence(struct psb_mmu_pd *pd, 
uint32_t start_pfn,
        do {
                next = psb_pd_addr_end(addr, end);
                pt = psb_mmu_pt_alloc_map_lock(pd, addr);
-               if (!pt) {
-                       ret = -ENOMEM;
+               if (!pt)
                        goto out;
-               }
+
                do {
                        pte = psb_mmu_mask_pte(start_pfn++, type);
                        psb_mmu_set_pte(pt, addr, pte);
-- 
2.5.0

Reply via email to