Hello, On 2016-03-30 13:34, Benjamin Gaignard wrote: > The original patches have been done by Marek: > https://lists.freedesktop.org/archives/dri-devel/2016-January/099572.html > > I have just adapt them to make zpos depend on plane and no more on drm core. > > Since zpos range can be define per plane normalize function takes care of > the min and max before compute normalized zpos value.
Thanks for handling this. I was terribly busy with internal stuff and had no time to check all my emails. Usually if one continues someone else patches, it is a good practice to somehow credit the original author in the final patch. If changes are small, I usually keep the original authorship and only add note before my signoff (see commit 855ed04a3758b205e84b269f92d26ab36ed8e2f7 for the example). When the whole code has been rewritten, modified or heavily extended, I changed authorship and added respective note to the commit message (see commit e8d9d1f5485b52ec3c4d7af839e6914438f6c285 for such example). Feel free to use any of those styles. > Benjamin Gaignard (2): > drm: add generic zpos property > drm: sti: use generic zpos for plane > > Documentation/DocBook/gpu.tmpl | 10 ++ > drivers/gpu/drm/Makefile | 2 +- > drivers/gpu/drm/drm_atomic.c | 4 + > drivers/gpu/drm/drm_atomic_helper.c | 6 + > drivers/gpu/drm/drm_blend.c | 242 > ++++++++++++++++++++++++++++++++++++ > drivers/gpu/drm/drm_crtc_internal.h | 3 + > drivers/gpu/drm/sti/sti_mixer.c | 2 +- > drivers/gpu/drm/sti/sti_plane.c | 82 +++++------- > drivers/gpu/drm/sti/sti_plane.h | 2 - > include/drm/drm_crtc.h | 17 +++ > 10 files changed, 314 insertions(+), 56 deletions(-) > create mode 100644 drivers/gpu/drm/drm_blend.c > Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland