On 30 September 2015 at 14:46, Inki Dae <inki.dae at samsung.com> wrote: > Hi Emil, > > On 2015ë 09ì 30ì¼ 21:19, Emil Velikov wrote: >> Hi Inki, >> >> On 30 September 2015 at 12:21, Inki Dae <inki.dae at samsung.com> wrote: >>> This patch removes unnecessary pm suspend/resume functions. >>> >>> All kms sub drivers will be controlled by top of Exynos drm driver >>> and connector dpms so these sub drivers shouldn't have their own >>> pm interfaces. >>> >> Not sure if you've noticed but this patch seems to do the opposite of >> what Gustavo was aiming with an earlier series [1]. > > I removed just the interfaces related to sleep pm not runtime pm. From > long ago, Linux DRM drivers - especially ARM DRM drivers - have been > stepping forward to a integrated DRM driver so it'd be reasonable for > sleep pm operations of all KMS drivers are controlled by top of DRM > driver. It means that Exynos drm driver has already sleep pm interfaces. > > However, I think a power domain of each kms device couldn't be > controlled by the top in case of ARM SoC because kms devices can use a > different power domain each other according to Vendor SoC so runtime pm > should be controlled by each kms driver, which will be triggered by DRM top. > > And Gustavo's patch set you mentioned - now being reviewed - will add > only runtime pm interfaces to each kms driver. > Ack. Seems like I misread your patch. Thank you for the comprehensive answer and apologies for the noise.
Thanks Emil
