Op 09-09-15 om 13:59 schreef Daniel Vetter: > On Wed, Sep 9, 2015 at 1:51 PM, Ville Syrjälä > <ville.syrjala at linux.intel.com> wrote: >> On Wed, Sep 09, 2015 at 01:46:21PM +0200, Maarten Lankhorst wrote: >>> This may cause issues because encoders are already destroyed so removing >>> active primaries may use freed memory. Instead free the fb directly, >>> ignoring refcount. >> So what about fixing the cause, not the symptom? That is remove >> framebuffers before nuking crtc/encoders/etc. > Also by that point we shouldn't have any framebuffers left (the > WARN_ON is for that), so not sure what's the point of this patch. > -Daniel Yes, but the current way would crash on atomic because encoders are already done. This removes a caller of drm_framebuffer_remove and uses the correct destroy function regardless even when refcounts are leaked. :)
~Maarten
