On Thu, Oct 08, 2015 at 12:12:36PM -0400, Alex Deucher wrote: > From: Maruthi Srinivas Bayyavarapu <Maruthi.Bayyavarapu at amd.com> > > Added a qurik to assign different base addresses for different > dwc controllers present on platform for playback and capture.
I don't understand what the above means, sorry. Normally the address ranges for devices are supplied via resources when the device is registered. > + if (dev->quirks & DW_I2S_QUIRK_MULTI_DWC) { > + if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) { > + i2s_write_reg(dev->i2s_pbase, CER, 0); > + i2s_write_reg(dev->i2s_pbase, IER, 0); > + } else { > + i2s_write_reg(dev->i2s_cbase, CER, 0); > + i2s_write_reg(dev->i2s_cbase, IER, 0); > + } This looks like it might be part of the previous change to merge separate playback and capture instances of the controller into one device rather than a separate change? But perhaps what this is saying is also that the controller instances aren't actually totally separate after all and the prior change maps well onto the hardware... -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 473 bytes Desc: not available URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20151023/4a18b5ed/attachment.sig>